directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Felix Knecht <fel...@apache.org>
Subject Re: svn commit: r627296 - /directory/studio/branches/studio-maven/pom.xml
Date Wed, 13 Feb 2008 08:35:14 GMT
Pierre-Arnaud Marcelot schrieb:
> You're right, I just tested it too.
>
> I have the same issue on the apacheds trunk right now.
>
> The surefire plugin version has been modified in the project pom just 
> before releasing the version 9.
>
>     @@ -128,7 +143,7 @@
>             <plugin>
>               <groupId>org.apache.maven.plugins</groupId>
>               <artifactId>maven-surefire
>     -plugin</artifactId>
>     -          <version>2.3</version>
>     +          <version>2.4.1</version>
>               <configuration>
>                 <argLine>-Xmx1024m</argLine>
>               </configuration>
>
>
> It is failing because it's not finding any test to run in the abstract 
> test case classes (which is plain normal... :( ).
>
> Your patch works great, but you're right we never know. Maybe there 
> are some important test cases starting with "Abstract"...
>
> We could maybe also add a blank test in each abstract test case... 
> (Just to please the plugin).

We can also add exactly those (abstract) testcases which are not to be 
executed instead of a general matching pattern like Abstract*.java. OTH 
I wonder if it's good practice to have real test cases in an abstract class?
Just adding an empty test case to please a tool we use seems quite odd.

Felix
>
> Pierre-Arnaud
>
> On Feb 13, 2008 8:47 AM, Felix Knecht <felixk@apache.org 
> <mailto:felixk@apache.org>> wrote:
>
>     Something must have changed (probably in the surefire plugin), but
>     using
>     released apache directory project 9 as parent I get test failures
>     whereas it passes using the older version 8.
>
>     That's why I haven't updated parent pom tag.
>
>     Regards
>     Felix
>
>
>
>     felixk@apache.org <mailto:felixk@apache.org> schrieb:
>     > Author: felixk
>     > Date: Tue Feb 12 23:43:39 2008
>     > New Revision: 627296
>     >
>     > URL: http://svn.apache.org/viewvc?rev=627296&view=rev
>     <http://svn.apache.org/viewvc?rev=627296&view=rev>
>     > Log:
>     > Use released versions of directory shared modules
>     >
>     > Modified:
>     >     directory/studio/branches/studio-maven/pom.xml
>     >
>     > Modified: directory/studio/branches/studio-maven/pom.xml
>     > URL:
>     http://svn.apache.org/viewvc/directory/studio/branches/studio-maven/pom.xml?rev=627296&r1=627295&r2=627296&view=diff
>     <http://svn.apache.org/viewvc/directory/studio/branches/studio-maven/pom.xml?rev=627296&r1=627295&r2=627296&view=diff>
>     >
>     ==============================================================================
>     > --- directory/studio/branches/studio-maven/pom.xml (original)
>     > +++ directory/studio/branches/studio-maven/pom.xml Tue Feb 12
>     23:43:39 2008
>     > @@ -1641,17 +1641,17 @@
>     >        <dependency>
>     >          <groupId>org.apache.directory.shared</groupId>
>     >          <artifactId>shared-ldap</artifactId>
>     > -        <version>0.9.8-SNAPSHOT</version>
>     > +        <version>0.9.8</version>
>     >        </dependency>
>     >        <dependency>
>     >          <groupId>org.apache.directory.shared</groupId>
>     >          <artifactId>shared-asn1</artifactId>
>     > -        <version>0.9.8-SNAPSHOT</version>
>     > +        <version>0.9.8</version>
>     >        </dependency>
>     >        <dependency>
>     >          <groupId>org.apache.directory.shared</groupId>
>     >          <artifactId>shared-converter</artifactId>
>     > -        <version>0.9.8-SNAPSHOT</version>
>     > +        <version>0.9.8</version>
>     >        </dependency>
>     >
>     >        <!-- Other dependencies -->
>     >
>     >
>     >
>
>


Mime
View raw message