Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (athena.apache.org: domain of akarasulu@gmail.com
 designates 209.85.146.181 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:sender:to:subject:mime-version:content-type:x-google-sender-auth;
        b=MQBOJeuI6ULZf5CtkFgcCq7xsIr4kDCWtYCFgf+rc9Y3qdfz8IdnYbBTm2SUZFOT14KJi/zZ4qOf1EBBfr5MV4/owyOgj/zoMt274cknY+F300E4mPWMfuzZlR4ompyBjlBB60qSodA8xxEE3pfy+O0SVxDsrMcaVCHylII2fiE=
Message-ID: <a32f6b020710151730x5a051ef7p60988ed0ce078083@mail.gmail.com>
Date: Mon, 15 Oct 2007 20:30:59 -0400
From: "Alex Karasulu" <akarasulu@apache.org>
Sender: akarasulu@gmail.com
To: "Apache Directory Developers List" <dev@directory.apache.org>
Subject: [ApacheDS] Removing chain pattern from SASL binds
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_30643_20808924.1192494659629"

------=_Part_30643_20808924.1192494659629
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi Emmanuel,

Most of the logic in the chain can be moved out into simple stupid methods
removing much of
the complexity.  For now we might just flatten and use a method to do what
each link was doing.
I have no idea why the chain pattern was used in the first place.  Do you
know?  We might use
CoR in the core for intercepting calls but here I cannot see any reason for
it.  It's a damn mess.

After you're done refactoring I might clean up a tiny bit more.  I think we
need to take a pass
to just review the code perhaps looking for more cleanups we can make.  Then
we can get on
with Phase II.  If you like we can do a peer review of the entire state of
the server.  Perhaps
around the weekend or right after. WDYT?

I'll be hard to reach tomorrow but tonight I will review some of those new
interfaces for Phase II.

Alex

------=_Part_30643_20808924.1192494659629
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi Emmanuel,<br><br>Most of the logic in the chain can be moved out into simple stupid methods removing much of <br>the complexity.&nbsp; For now we might just flatten and use a method to do what each link was doing.<br>I have no idea why the chain pattern was used in the first place.&nbsp; Do you know?&nbsp; We might use 
<br>CoR in the core for intercepting calls but here I cannot see any reason for it.&nbsp; It&#39;s a damn mess.<br><br>After you&#39;re done refactoring I might clean up a tiny bit more.&nbsp; I think we need to take a pass <br>to just review the code perhaps looking for more cleanups we can make.&nbsp; Then we can get on 
<br>with Phase II.&nbsp; If you like we can do a peer review of the entire state of the server.&nbsp; Perhaps <br>around the weekend or right after. WDYT? <br><br>I&#39;ll be hard to reach tomorrow but tonight I will review some of those new interfaces for Phase II.
<br><br>Alex<br><br><br><br>

------=_Part_30643_20808924.1192494659629--