From dev-return-21929-apmail-directory-dev-archive=directory.apache.org@directory.apache.org Sat Oct 06 05:24:00 2007 Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 99776 invoked from network); 6 Oct 2007 05:23:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Oct 2007 05:23:59 -0000 Received: (qmail 13705 invoked by uid 500); 6 Oct 2007 05:23:47 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 13656 invoked by uid 500); 6 Oct 2007 05:23:47 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 13645 invoked by uid 99); 6 Oct 2007 05:23:47 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Oct 2007 22:23:47 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of akarasulu@gmail.com designates 209.85.146.176 as permitted sender) Received: from [209.85.146.176] (HELO wa-out-1112.google.com) (209.85.146.176) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Oct 2007 05:23:50 +0000 Received: by wa-out-1112.google.com with SMTP id m38so948310waf for ; Fri, 05 Oct 2007 22:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:mime-version:content-type:x-google-sender-auth; bh=AJzid4/fFKr38WbjZTOzihYHeZ5zrEe9PJuMg8MmOdg=; b=Jntnxmo+lyifyyYWsD1AhQVP1NoPUcjDFQEr5Lt+wpzGzDR/atpurwZK3jCW7A0ndpLn8BXABG70JFHSEFGdmutftYSbXSgj83+wBTtzJ5Lu9i49Rs0ketMBpLE4SP0aYSMI1vUYtqAtT350RYXPc9SLrStQH2cFtEMaHR0djP0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:mime-version:content-type:x-google-sender-auth; b=Mffn617ZxIDzdPFwCDH8vOCFKma+WV7Qk3X779WlPv4SsVbYh0jTRwvtlIMRv+Mbi5hTsqb/0jNaz8QOjCYPX0IwApuOd1I1ZiSVHwDnScYSIc01aBRaKOVnvhUhjO5cbXq/HEsLHYbX4Pz0rDIWLdHLEbtsfb5yZzMymaP9XU8= Received: by 10.114.178.1 with SMTP id a1mr8101527waf.1191648209568; Fri, 05 Oct 2007 22:23:29 -0700 (PDT) Received: by 10.115.76.8 with HTTP; Fri, 5 Oct 2007 22:23:29 -0700 (PDT) Message-ID: Date: Sat, 6 Oct 2007 01:23:29 -0400 From: "Alex Karasulu" Sender: akarasulu@gmail.com To: "Apache Directory Developers List" Subject: Issues with tests MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_34576_16991712.1191648209507" X-Google-Sender-Auth: fd186247bcbc5ece X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_34576_16991712.1191648209507 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Enrique, There were a slew of copy and paste problems that I had to fix all the tests created recently: * Sasl tests * NTP test * Kerberos interceptor based tests Furthermore they don't seem to follow the pattern of using the AbstractTestCase and AbstractServerTestCase classes. It would help a lot if you tried to use these instead of duplicating the setUp() code. Eventually switching to the FastXXXITest that Emmanuel setup should be the best. I'm not going to go into the Sasl mechanism but there are copy and paste issues there as well. Regardless the BindHandler that was copied and pasted had several issues anyway. I know it was not the best model to follow. We need to seriously rework the LdapProtocolProvider. It's got major issues in general besides the SASL chain based mechanism which should be removed IMO. Thanks, Alex ------=_Part_34576_16991712.1191648209507 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Enrique,

There were a slew of copy and paste problems that I had to fix all the tests created recently:

  * Sasl tests
  * NTP test
  * Kerberos interceptor based tests

Furthermore they don't seem to follow the pattern of using the AbstractTestCase and AbstractServerTestCase
classes.  It would help a lot if you tried to use these instead of duplicating the setUp() code.   Eventually
switching to the FastXXXITest that Emmanuel setup should be the best.

I'm not going to go into the Sasl mechanism but there are copy and paste issues there as well.  Regardless
the BindHandler that was copied and pasted had several issues anyway.  I know it was not the best model
to follow.  We need to seriously rework the LdapProtocolProvider.  It's got major issues in general besides the
SASL chain based mechanism which should be removed IMO.

Thanks,
Alex

------=_Part_34576_16991712.1191648209507--