Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 43268 invoked from network); 24 Aug 2007 13:15:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 24 Aug 2007 13:15:52 -0000 Received: (qmail 47583 invoked by uid 500); 24 Aug 2007 13:15:48 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 47543 invoked by uid 500); 24 Aug 2007 13:15:47 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 47532 invoked by uid 99); 24 Aug 2007 13:15:47 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Aug 2007 06:15:47 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Aug 2007 13:15:50 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 8A8AE71420C for ; Fri, 24 Aug 2007 06:15:30 -0700 (PDT) Message-ID: <14932497.1187961330554.JavaMail.jira@brutus> Date: Fri, 24 Aug 2007 06:15:30 -0700 (PDT) From: "Emmanuel Lecharny (JIRA)" To: dev@directory.apache.org Subject: [jira] Updated: (DIRSERVER-454) Refactor to remove dup code from commit 239501 In-Reply-To: <19013001.1124846828096.JavaMail.jira@ajax.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DIRSERVER-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emmanuel Lecharny updated DIRSERVER-454: ---------------------------------------- Priority: Major (was: Trivial) Affects Version/s: 1.5.0 Fix Version/s: 1.5.2 This is a very interesting JIRA. A lot has to be done, ad we discussed the subject with pam 10 minutes ago. We should define and use a common SchemaCheckers which can be used by both client and server, assuming that we do the very same checks on both side. Raised to major for this reason. > Refactor to remove dup code from commit 239501 > ---------------------------------------------- > > Key: DIRSERVER-454 > URL: https://issues.apache.org/jira/browse/DIRSERVER-454 > Project: Directory ApacheDS > Issue Type: Improvement > Components: core > Affects Versions: 1.5.0 > Reporter: Alex Karasulu > Fix For: 1.5.2 > > > The following commit revision included code changes that were quick and dirty: > http://svn.apache.org/viewcvs.cgi?rev=239501&view=rev > These changes were made to resolve the issue DIREVE-230 here: > http://issues.apache.org/jira/browse/DIREVE-230 > There's a lot of duplicate code here that can be properly refactored. Likewise for the test case. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.