directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRSERVER-1048) Need to improve LDIF load procedures
Date Fri, 31 Aug 2007 00:28:30 GMT

    [ https://issues.apache.org/jira/browse/DIRSERVER-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523969
] 

Emmanuel Lecharny commented on DIRSERVER-1048:
----------------------------------------------

I don't exactly remember the reasons I said I didn't think it was a good idea ... Anyways,
I'm getting old, and it may be normal that I'm loosing my memory.

What were we talking about ? errr...

Ok, I suggest we use the shared-ldap LdifReader in place of this LdifLoader which seems totally
broken up to a point it needs to be patched. There are at least two big problems :
- this class is badly misplaced : what the hell is a Ldif manipulation class is doing into
a protocol pakcage ?
- this ldif loader does not accept modificatiosn, when LdifReader accept plain entries _or_
modifications (this is an exclusive or, but if you just use modifications, you can also inject
entries, assuming you use the 'add' changetype)

In my mind, using the shared-ldap ldif file should do the trick.

> Need to improve LDIF load procedures
> ------------------------------------
>
>                 Key: DIRSERVER-1048
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1048
>             Project: Directory ApacheDS
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.5.1
>            Reporter: Chris Custine
>            Priority: Minor
>             Fix For: 1.5.2
>
>         Attachments: DIRSERVER-1048.LdifFileLoader.patch
>
>
> The LDIF load routine needs some general clean up, and needs to allow modify of existing
entries in order to add administrativeRole attributes, etc.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message