directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enrique Rodriguez" <enriqu...@gmail.com>
Subject Re: svn commit: r544690 - /directory/apacheds/trunk/protocol-ldap/src/main/java/org/apache/directory/server/ldap/support/bind/ConfigureChain.java
Date Wed, 06 Jun 2007 00:27:05 GMT
On 6/5/07, elecharny@apache.org <elecharny@apache.org> wrote:
> Author: elecharny
> Date: Tue Jun  5 17:09:01 2007
> New Revision: 544690
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=544690
> Log:
> Replaced the stack trace by a simple message. As such a message
> is now dumped for each bind request, with a full stack trace we will
> have a gigantic log file on a heavy loaded server
> ...
> @@ -71,7 +71,7 @@
>          saslProps.put( "com.sun.security.sasl.digest.realm", getActiveRealms( config
) );
>          session.setAttribute( "saslProps", saslProps );
>
> -        session.setAttribute( "saslHost", config.getSaslHost() );
> +        session.setAttribute( "saslProps", config.getSaslHost() );
>          session.setAttribute( "baseDn", config.getSearchBaseDn() );
>
>          Set activeMechanisms = getActiveMechanisms( config );
> @@ -86,7 +86,7 @@
>              catch ( ServiceConfigurationException sce )
>              {
>                  activeMechanisms.remove( "GSSAPI" );
> -                log.warn( sce.getMessage(), sce );
> +                log.warn( sce.getMessage() );

Changing the saslHost/saslProps attribute is a mistake.  It breaks the
SaslBindITest.  Can you please revert it?  If you intended a saslProps
change you also didn't note it in your commit message nor run the
integration tests.

While you're at it, can you revert the addition of the max time limit
and max size limit to StartupConfig/MutableStartupConfig?  There are
now do-nothing getter/setters there.

Enrique

Mime
View raw message