directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Lecharny <elecha...@apache.org>
Subject Re: svn commit: r544690 - /directory/apacheds/trunk/protocol-ldap/src/main/java/org/apache/directory/server/ldap/support/bind/ConfigureChain.java
Date Wed, 06 Jun 2007 00:36:30 GMT

> Changing the saslHost/saslProps attribute is a mistake.  It breaks the
> SaslBindITest.  Can you please revert it?  If you intended a saslProps
> change you also didn't note it in your commit message nor run the
> integration tests.

Fixed.

>
> While you're at it, can you revert the addition of the max time limit
> and max size limit to StartupConfig/MutableStartupConfig?  There are
> now do-nothing getter/setters there.

I prefer keeping them for a little while, for the sake of users who 
still have an older version of server.xml. Anyway, they are do-nothing, 
which is better than do-harm.

Can you please fill a JIRA so that we remind to remove them when we will 
have agreed on a new configuration file ?

Thanks


Mime
View raw message