directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Karasulu" <akaras...@apache.org>
Subject Re: svn commit: r542147 - in /directory/apacheds/trunk/kerberos-shared/src/main/java/org/apache/directory/server/kerberos/shared: crypto/encryption/DesStringToKey.java messages/value/HostAddress.java
Date Mon, 28 May 2007 14:38:47 GMT
On 5/28/07, Emmanuel Lecharny <elecharny@gmail.com> wrote:

> For instance, in ChainGuard.java, you have such invocations in the
> execute method :
>         log.debug( "Is simple:       " + request.isSimple() );
>         log.debug( "SASL mechanism:  " + request.getSaslMechanism() );
>         log.debug( "Credentials:     " + request.getCredentials() );
>
> Even if debug is disabled, this will invoke the request.XXX methods,
> and create a String concatenating the result with the message, String
> which will be discarded immediatly. When I did some profiling, I found
> that such calls cost as much as 5 to 10 % of the global CPU consummed
> inside the server.


Yes yes this is a needless waste of CPU cycles.

Alex

Mime
View raw message