directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Karasulu" <akaras...@apache.org>
Subject Re: svn commit: r541888 - in /directory/daemon/trunk: bootstrappers/pom.xml plugin/pom.xml pom.xml
Date Sat, 26 May 2007 14:48:20 GMT
Hi Emmanuel,

I don't think you need to add a pluginManagement section to all leaf module
POMs.
If we add these pluginManagement sections to the root POMs of all
subprojects (see
below) then they get inherited by the leaf module POMs:

apacheds/pom.xml
daemon/pom.xml
shared/pom.xml

This way you can manage the plugin versions in one place.  This was the main
reason
why the maven folks came up with pluginManagement sections.  However if we
put a
pluginManagement section into every pom and replicate this information then
we're
foregoing the benefits we could gain by having one centralized
pluginManagement section
for each subproject.

Regards,
Alex

On 5/26/07, elecharny@apache.org <elecharny@apache.org> wrote:
>
> Author: elecharny
> Date: Sat May 26 05:31:15 2007
> New Revision: 541888
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=541888
> Log:
> Added some NL in bootstrapper/pom.xml for clarity
> Added a PluginManagement section in pom.xml, declaring all the used
> plugins
> Declared common configuration for the plugins in pom.xml
> Removed configuration from sub-poms
>
> Modified:
>     directory/daemon/trunk/bootstrappers/pom.xml
>     directory/daemon/trunk/plugin/pom.xml
>     directory/daemon/trunk/pom.xml
>
> Modified: directory/daemon/trunk/bootstrappers/pom.xml
> URL:
> http://svn.apache.org/viewvc/directory/daemon/trunk/bootstrappers/pom.xml?view=diff&rev=541888&r1=541887&r2=541888
>
> ==============================================================================
> --- directory/daemon/trunk/bootstrappers/pom.xml (original)
> +++ directory/daemon/trunk/bootstrappers/pom.xml Sat May 26 05:31:15 2007
> @@ -9,10 +9,12 @@
>    <artifactId>daemon-bootstrappers</artifactId>
>    <name>Apache Directory Daemon Bootstrappers</name>
>    <packaging>jar</packaging>
> +
>    <description>
>      Daemon bootstrappers which initialize a classloader with jars laid
> out in
>      an installation footprint.
>    </description>
> +
>    <distributionManagement>
>      <site>
>        <id>apache.websites</id>
> @@ -21,6 +23,7 @@
>        </url>
>      </site>
>    </distributionManagement>
> +
>    <build>
>      <plugins>
>        <plugin>
>
> Modified: directory/daemon/trunk/plugin/pom.xml
> URL:
> http://svn.apache.org/viewvc/directory/daemon/trunk/plugin/pom.xml?view=diff&rev=541888&r1=541887&r2=541888
>
> ==============================================================================
> --- directory/daemon/trunk/plugin/pom.xml (original)
> +++ directory/daemon/trunk/plugin/pom.xml Sat May 26 05:31:15 2007
> @@ -9,36 +9,43 @@
>    <artifactId>daemon-plugin</artifactId>
>    <name>Apache Directory Daemon Plugin (Maven 2)</name>
>    <packaging>maven-plugin</packaging>
> +
>    <description>
>      A plugin that builds installers using bootstrappers and
> commons-daemon procrun and jsvc
>    </description>
> +
>    <distributionManagement>
>      <site>
>        <id>apache.websites</id>
>
> <url>scp://minotaur.apache.org/www/directory.apache.org/newsite/subprojects/daemon/</url>
>      </site>
>    </distributionManagement>
> +
>    <dependencies>
>      <dependency>
>        <groupId>${pom.groupId}</groupId>
>        <artifactId>daemon-bootstrappers</artifactId>
>        <version>${pom.version}</version>
>      </dependency>
> +
>      <dependency>
>        <groupId>org.apache.maven</groupId>
>        <artifactId>maven-plugin-api</artifactId>
>        <version>2.0.1</version>
>      </dependency>
> +
>      <dependency>
>        <groupId>org.apache.maven</groupId>
>        <artifactId>maven-project</artifactId>
>        <version>2.0</version>
>      </dependency>
> +
>      <dependency>
>        <groupId>plexus</groupId>
>        <artifactId>plexus-utils</artifactId>
>        <version>1.0.2</version>
>      </dependency>
> +
>      <dependency>
>        <groupId>izpack</groupId>
>        <artifactId>standalone-compiler</artifactId>
> @@ -51,14 +58,9 @@
>        <plugin>
>          <groupId>org.apache.maven.plugins</groupId>
>          <artifactId>maven-compiler-plugin</artifactId>
> -        <configuration>
> -          <source>1.5</source>
> -          <target>1.5</target>
> -        </configuration>
>        </plugin>
>
>      </plugins>
>    </build>
>
> </project>
> -
>
> Modified: directory/daemon/trunk/pom.xml
> URL:
> http://svn.apache.org/viewvc/directory/daemon/trunk/pom.xml?view=diff&rev=541888&r1=541887&r2=541888
>
> ==============================================================================
> --- directory/daemon/trunk/pom.xml (original)
> +++ directory/daemon/trunk/pom.xml Sat May 26 05:31:15 2007
> @@ -42,18 +42,53 @@
>    </scm>
>
>    <build>
> -  <pluginManagement>
> +    <pluginManagement>
> +      <plugins>
> +
> +        <plugin>
> +          <groupId>org.apache.maven.plugins</groupId>
> +          <artifactId>maven-surefire-plugin</artifactId>
> +          <version>2.3</version>
> +        </plugin>
> +
> +        <plugin>
> +          <groupId>org.apache.maven.plugins</groupId>
> +          <artifactId>maven-jar-plugin</artifactId>
> +          <version>2.1</version>
> +        </plugin>
> +
> +        <plugin>
> +          <groupId>org.apache.maven.plugins</groupId>
> +          <artifactId>maven-compiler-plugin</artifactId>
> +          <version>2.0.2</version>
> +        </plugin>
> +
> +      </plugins>
> +    </pluginManagement>
> +
>      <plugins>
> +
>        <plugin>
>          <groupId>org.apache.maven.plugins</groupId>
>          <artifactId>maven-surefire-plugin</artifactId>
> -        <version>2.1.3</version>
>          <configuration>
>            <argLine>-Xmx1024m</argLine>
>          </configuration>
>        </plugin>
> +
> +      <plugin>
> +        <groupId>org.apache.maven.plugins</groupId>
> +        <artifactId>maven-compiler-plugin</artifactId>
> +        <configuration>
> +          <source>1.5</source>
> +          <target>1.5</target>
> +          <optimize>true</optimize>
> +          <showDeprecations>true</showDeprecations>
> +          <encoding>ISO-8859-1</encoding>
> +        </configuration>
> +      </plugin>
> +
>      </plugins>
> -  </pluginManagement>
>    </build>
> </project>
>
>
>
>

Mime
View raw message