Return-Path: 
 <dev-return-17545-apmail-directory-dev-archive=directory.apache.org@directory.apache.org>
Delivered-To: apmail-directory-dev-archive@www.apache.org
Received: (qmail 33519 invoked from network); 16 Apr 2007 04:42:32 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 16 Apr 2007 04:42:32 -0000
Received: (qmail 22553 invoked by uid 500); 16 Apr 2007 04:42:38 -0000
Delivered-To: apmail-directory-dev-archive@directory.apache.org
Received: (qmail 22509 invoked by uid 500); 16 Apr 2007 04:42:37 -0000
Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@directory.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@directory.apache.org>
List-Post: <mailto:dev@directory.apache.org>
List-Id: <dev.directory.apache.org>
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Delivered-To: mailing list dev@directory.apache.org
Received: (qmail 22498 invoked by uid 99); 16 Apr 2007 04:42:37 -0000
Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Apr 2007 21:42:37 -0700
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (herse.apache.org: local policy)
Received: from [72.51.41.97] (HELO ns2.scheduleworld.com) (72.51.41.97)
    by apache.org (qpsmtpd/0.29) with SMTP; Sun, 15 Apr 2007 21:42:30 -0700
Received: from 10.0.2.93 ([10.0.2.93])
          by ns2.scheduleworld.com (JAMES SMTP Server 2.2.1-RC1) with SMTP ID
 43
          for <dev@directory.apache.org>;
          Mon, 16 Apr 2007 00:41:55 -0400 (EDT)
Message-ID: <4622FE84.8050207@ScheduleWorld.com>
Date: Mon, 16 Apr 2007 00:41:40 -0400
From: Mark Swanson <mark@ScheduleWorld.com>
User-Agent: Thunderbird 1.5.0.10 (X11/20070221)
MIME-Version: 1.0
To: Apache Directory Developers List <dev@directory.apache.org>
Subject: Code comments: custom Authenticator implementations
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org

Hello,

I have a shiny new Authenticator implementation running (mostly, I 
think) and came across a  comment that I think should be changed:

--- AbstractAuthenticator.java  2007-02-21 16:25:53.000000000 -0500
+++ AbstractAuthenticator.java.new      2007-04-16 00:40:12.000000000 -0400
@@ -144,13 +144,14 @@
      /**
       * Returns a new {@link LdapPrincipal} instance whose value is the 
specified
       * <tt>name</tt>.
-     *
+     *
+        * This method is available for custom Authenticator 
implementations.
+        *
       * @param name the distinguished name of the X.500 principal
       * @param authenticationLeve
       * @return the principal for the <tt>name</tt>
       * @throws NamingException if there is a problem parsing <tt>name</tt>
       */
-    // does not seem to be used
      protected static LdapPrincipal createLdapPrincipal( String name, 
AuthenticationLevel authenticationLeve )
          throws NamingException
      {

I could not create a custom Authenticator without createLdapPrincipal().
Of course, unless I can. :-) (then please show me how)

Cheers.

-- 
http://www.ScheduleWorld.com/
Free Google Calendar synchronization with Outlook, Evolution,
cell phones, BlackBerry, PalmOS, Exchange, Mozilla, Thunderbird,
Pocket PC/Windows Mobile. Also sync tasks, notes and contacts!
WebDAV, vfreebusy, RSS, LDAP, iCalendar, iTIP, iMIP support.