From dev-return-16516-apmail-directory-dev-archive=directory.apache.org@directory.apache.org Thu Mar 15 19:55:56 2007 Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 78454 invoked from network); 15 Mar 2007 19:55:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Mar 2007 19:55:56 -0000 Received: (qmail 26036 invoked by uid 500); 15 Mar 2007 19:56:03 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 26005 invoked by uid 500); 15 Mar 2007 19:56:03 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 25994 invoked by uid 99); 15 Mar 2007 19:56:03 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Mar 2007 12:56:03 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of akarasulu@gmail.com designates 66.249.82.226 as permitted sender) Received: from [66.249.82.226] (HELO wx-out-0506.google.com) (66.249.82.226) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Mar 2007 12:55:52 -0700 Received: by wx-out-0506.google.com with SMTP id h31so316500wxd for ; Thu, 15 Mar 2007 12:55:32 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:references:x-google-sender-auth; b=d87uVUPPawLVkn/lb3WhkRiVFBrkas4HHJRlFrkKG/xie1Z3ihpcKPU6MFYmfhNkcDxLBQBC4+X9nVmTyltGoSN8Hlrbbv7oUOYSzeXptwjgKT0sBkED4xxZrnRPgUBP1Isss82yX15z2KVPpyFZgnN0MnHTNXjRQtGO5PyyYV8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:references:x-google-sender-auth; b=Ft7ibzJ8pfNiU63LnhOc6u/X4WfSpDlkHQl0iTlTZ0LtaArASUJzAC7KZJ+zrTyEYCjT6ZpCTmDORpArUex7zI/+/XgOVq6jgX5a6F8uyQLD/8FotcCR2x/MbfTNt3DR6GSN1lMGKwxAo2HauKhEEMsdPBRS0NhT/0wpdyFIreE= Received: by 10.70.109.12 with SMTP id h12mr1738906wxc.1173988532010; Thu, 15 Mar 2007 12:55:32 -0700 (PDT) Received: by 10.70.78.18 with HTTP; Thu, 15 Mar 2007 12:55:31 -0700 (PDT) Message-ID: Date: Thu, 15 Mar 2007 15:55:31 -0400 From: "Alex Karasulu" Sender: akarasulu@gmail.com To: "Apache Directory Developers List" Subject: Re: [SASL] SASL configuration, part 2 In-Reply-To: <768dcb2e0703132244s3d5bac7ficb4df6436afd3c16@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_33473_11337275.1173988531800" References: <568753d90703132036g3f387f58paa5cb1c87cb1c91e@mail.gmail.com> <768dcb2e0703132244s3d5bac7ficb4df6436afd3c16@mail.gmail.com> X-Google-Sender-Auth: 66a588e2a63e52ce X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_33473_11337275.1173988531800 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Ok so you basically have this LDAPConfiguration bean contained under the ServerStartupConfiguration? Meaning I would get and set the LDAPConfiguration bean on the ServerStartupConfiguration? In terms of deps this sounds good. You have the LDAPConfig bean in the protocol module which the server-jndi module depends on. So this is nice because then the server-jndi can just have the subordinate object under the SSConfig bean. If this is correct it sounds good to me. I looked at the doco too just now ... config looks cleaner. However this bean is under the configuration bean in the server.xml file I suspect. Is this correct? Can you elaborate a tiny bit more on the configuration changes in the doco just so there are no questions? Alex On 3/14/07, Trustin Lee wrote: > > On 3/14/07, Enrique Rodriguez wrote: > > Hi, Directory developers, > > > > I wrote a quick LdapConfiguration bean and moved minor config to it, > > to make sure I knew how to get a bean loaded and into the > > ServerContextFactory. I'm now ready to move more parameters to this > > bean. In case it wasn't clear from my last email on consolidating > > LDAP protocol config into a bean called LdapConfiguration and placing > > it in the 'protocol-ldap' module, I mocked-up an example of what > > configuring such a bean might look like: > > > > > http://cwiki.apache.org/confluence/display/DIRxSBOX/LDAP+Protocol+Configuration > > > > As you can see this combines the parameters used by the LDAP protocol > > in their own bean and then adds in the required parameters currently > > hard-coded in SASL's ConfigureChain. To be clear, this REMOVES LDAP > > protocol parameters from the StartupConfiguration hierarchy. Besides > > having a nice but minor effect on our dependency graph, IMO it is also > > clearer for admins to have all the LDAP protocol config in one place. > > > > I'd like to wire this up for real and commit it. We can of course > > tweak names and do more advanced config later; mostly I want to make > > sure it's OK to make a moderately invasive change to > > StartupConfiguration/ServerContextFactory. I need to do something for > > SASL and I'd rather not pack more config options into the > > StartupConfiguration hierarchy. > > Looks good to me. > > Trustin > -- > what we call human nature is actually human habit > -- > http://gleamynode.net/ > -- > PGP Key ID: 0x0255ECA6 > ------=_Part_33473_11337275.1173988531800 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline
Ok so you basically have this LDAPConfiguration bean contained under the ServerStartupConfiguration?  Meaning I would get and set the LDAPConfiguration bean on the ServerStartupConfiguration?
 
In terms of deps this sounds good.  You have the LDAPConfig bean in the protocol module which the server-jndi module depends on.  So this is nice because then the server-jndi can just have the subordinate object under the SSConfig bean.
 
If this is correct it sounds good to me.  I looked at the doco too just now ... config looks cleaner.  However this bean is under the configuration bean in the server.xml file I suspect.  Is this correct?
 
Can you elaborate a tiny bit more on the configuration changes in the doco just so there are no questions?
 
Alex

 
On 3/14/07, Trustin Lee <trustin@gmail.com> wrote:
On 3/14/07, Enrique Rodriguez <enriquer9@gmail.com> wrote:
> Hi, Directory developers,
>
> I wrote a quick LdapConfiguration bean and moved minor config to it,
> to make sure I knew how to get a bean loaded and into the
> ServerContextFactory.  I'm now ready to move more parameters to this
> bean.  In case it wasn't clear from my last email on consolidating
> LDAP protocol config into a bean called LdapConfiguration and placing
> it in the 'protocol-ldap' module, I mocked-up an example of what
> configuring such a bean might look like:
>
> http://cwiki.apache.org/confluence/display/DIRxSBOX/LDAP+Protocol+Configuration
>
> As you can see this combines the parameters used by the LDAP protocol
> in their own bean and then adds in the required parameters currently
> hard-coded in SASL's ConfigureChain.  To be clear, this REMOVES LDAP
> protocol parameters from the StartupConfiguration hierarchy.  Besides
> having a nice but minor effect on our dependency graph, IMO it is also
> clearer for admins to have all the LDAP protocol config in one place.
>
> I'd like to wire this up for real and commit it.  We can of course
> tweak names and do more advanced config later; mostly I want to make
> sure it's OK to make a moderately invasive change to
> StartupConfiguration/ServerContextFactory.  I need to do something for
> SASL and I'd rather not pack more config options into the
> StartupConfiguration hierarchy.

Looks good to me.

Trustin
--
what we call human nature is actually human habit
--
http://gleamynode.net/
--
PGP Key ID: 0x0255ECA6

------=_Part_33473_11337275.1173988531800--