directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRSERVER-843) NPE in DnNormalizer
Date Sun, 04 Mar 2007 09:42:50 GMT

    [ https://issues.apache.org/jira/browse/DIRSERVER-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477766
] 

Emmanuel Lecharny commented on DIRSERVER-843:
---------------------------------------------

>From an end user perspective, yes, but this class is only used inside ApacheDS, and our
problem is that it might me called with any kind of object (when we expect String, LdapDN
or Name). We only need to throw an exception which will be catched at an upper level and transformed
to a valid Ldap error message (a NPE won't be catched).

However, even the exception seems to be a little bit too much. We might simply :
- create three methods, for each possible parameter (atm, we use instanceof ...)
- or simply use one single method which accept a String and nothing else

The API is not very consistant, at least ...

> NPE in DnNormalizer
> -------------------
>
>                 Key: DIRSERVER-843
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-843
>             Project: Directory ApacheDS
>          Issue Type: Bug
>    Affects Versions: 1.0.1, 1.5.0
>            Reporter: Emmanuel Lecharny
>             Fix For: 1.0.1, 1.5.0
>
>
> If we try to normalize a DN which is not an instance of String, Name or LdapDN? we might
get a NPE. 
> We should throw an exception instead of allowing such NPE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message