directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enrique Rodriguez" <enriqu...@gmail.com>
Subject Re: Proposed protocol-dns changes
Date Mon, 29 Jan 2007 04:52:09 GMT
On 1/16/07, Richard Wallace <rwallace@thewallacepack.net> wrote:
> Hello,
>
> Here are the first set of changes I'd like to contribute to the
> protocol-dns subproject.  Here's a list of things I've done.

In general this patch looks good, but it doesn't appear to contain 2
binary test PDU files, so 2 tests fail.

MX-QUERY.pdu
MX-RESPONSE.pdu

It looks like there may be an eventual requirement for an MX-TRAFFIC?
Here's the relevant section from the patch:

 }
Index: src/test/resources/org/apache/directory/server/dns/protocol/MX-RESPONSE.pdu
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream

Property changes on:
src/test/resources/org/apache/directory/server/dns/protocol/MX-RESPONSE.pdu
___________________________________________________________________
Name: svn:mime-type
   + application/octet-stream

Index: src/test/resources/org/apache/directory/server/dns/protocol/MX-TRAFFIC.libpcap
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream

Property changes on:
src/test/resources/org/apache/directory/server/dns/protocol/MX-TRAFFIC.libpcap
___________________________________________________________________
Name: svn:mime-type
   + application/octet-stream

Index: src/test/resources/org/apache/directory/server/dns/protocol/MX-QUERY.pdu
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream

Property changes on:
src/test/resources/org/apache/directory/server/dns/protocol/MX-QUERY.pdu
___________________________________________________________________
Name: svn:mime-type
   + application/octet-stream

Enrique

Mime
View raw message