Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 79171 invoked from network); 14 Nov 2006 13:42:00 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Nov 2006 13:42:00 -0000 Received: (qmail 36850 invoked by uid 500); 14 Nov 2006 13:42:10 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 36820 invoked by uid 500); 14 Nov 2006 13:42:09 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 36809 invoked by uid 99); 14 Nov 2006 13:42:09 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2006 05:42:09 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2006 05:41:58 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 3C11F7142CD for ; Tue, 14 Nov 2006 05:41:38 -0800 (PST) Message-ID: <6099373.1163511698243.JavaMail.jira@brutus> Date: Tue, 14 Nov 2006 05:41:38 -0800 (PST) From: "Emmanuel Lecharny (JIRA)" To: dev@directory.apache.org Subject: [jira] Commented: (DIRSERVER-760) reading .schema files at server start-up In-Reply-To: <17758845.1160663915139.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/DIRSERVER-760?page=comments#action_12449672 ] Emmanuel Lecharny commented on DIRSERVER-760: --------------------------------------------- Don't spend time on de-finalizing too much :) We have some problem with the way schema are dynamically loaded. It seems to work for a standard server, but integration tests are failing because they assume that schema have already been generated and try to load the classes. We have to fix that otherwise we wont be able to integrate the schema loading system. FYI, when we think that we have a correct version of the server, we check it by launching the following command : mvn -Dintegration test It launches a bunch of tests which are used to check that the embedable server still works. Here we have a massive failure. Not a big deal, though, but it need to be fix :) > reading .schema files at server start-up > ---------------------------------------- > > Key: DIRSERVER-760 > URL: http://issues.apache.org/jira/browse/DIRSERVER-760 > Project: Directory ApacheDS > Issue Type: New Feature > Components: core > Affects Versions: 1.5.1 > Environment: N/A > Reporter: Norval Hope > Attachments: schema_branch.patch, schema_branch.patch, schema_loader.patch > > > I am submitting a patch for a feature I required, and which I've seen a number of queries about on the DEV list. Currently the only way to get new .schema information into ApacheDS is to use the Maven2 plugin, requiring a rebuild of the server (not to mention working around problems like methods being generated which are too long for Java to handle). > Instead this patch adds support for reading of specified .schema files from server.xml at server startup, via a new interface SchemaLoader and a default implementation FileSystemSchemaLoader. The latter supports reading all files matching a specified regex in a specified directory (in which case users must be careful to ensure that files appear lexicographically before their dependant files, ala init.rc in Linux) or reading an ordered list of file names under a specified directory. An example server.xml snippet is as follows: > > > > > > > > > > > > > > > > > > > > ./ > > > > my1_openldap.schema > my2_openldap.schema > > > > > > noting that the Maven2 style approach is of course still supported where desired. A list is used so that multiple SchemaLoader implementations can be appended if required (which I do). > I have also included SchemaFromSearchConverter which can read a schema from another directory via conventional query, which may come in useful for people using ApacheDS as a virtual directory container of sorts. It is not required by the core patch and can be excluded if no generic use is seen for it. > A few issues are still outstanding: > 1. Is the patch seen as worthwhile by the DEV list and/or are there any issues with my implementation of it? > 2. At it's core the patch uses the OpenLdapSchemaParser to read the .schema files, which is currently only available in the Maven2 plugin artifact > org.apache.directory.server > apacheds-core-plugin > > which is a bit clunky as it means people need to include this jar in their classpath (or in the UberJar). Perhaps this parsing component should be separated from the rest of the maven plugin to tidy this up (I don't know maven well enough to do this myself). > > 3. If the feature and implementation are ok, what further steps should I take re preparing the patch for inclusion? > Thanks (by the way I was previously known as Norbert Reilly) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira