Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (asf.osuosl.org: domain of ersin.er@gmail.com designates
 64.233.166.181 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=tdxrrHn9saBSYOBW507ztri6Go3mEtK6WKv0yC6pjOVym90zuGCqoj4ydqDEhTBJIPDgki8HimrOAZn7PNZdqevl0thyQr5zh+9wcT91U5060LBUrd5nLJWJUBldSSPm2BAfXJ9pGo+MANrC8Qa5ihrPDrfrR6dkNsFwxaIZRJA=
Message-ID: <a1b4a6610608220315y76f6b668gf9278e9655baa9f3@mail.gmail.com>
Date: Tue, 22 Aug 2006 13:15:20 +0300
From: "Ersin Er" <ersin.er@gmail.com>
To: dev@directory.apache.org
Subject: Re: svn commit: r433483 - in /directory/branches/apacheds/1.0:
 core/src/main/java/org/apache/directory/server/core/schema/
 server-unit/src/test/java/org/apache/directory/server/
In-Reply-To: <a1b4a6610608212353o1718f47er9f81ae31af0acee1@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20060822031807.0FC2C1A981A@eris.apache.org>
	 <a1b4a6610608212353o1718f47er9f81ae31af0acee1@mail.gmail.com>

On 8/22/06, Ersin Er <ersin.er@gmail.com> wrote:
> On 8/22/06, akarasulu@apache.org <akarasulu@apache.org> wrote:
> > Author: akarasulu
> > Date: Mon Aug 21 20:18:05 2006
> > New Revision: 433483
> >
> > URL: http://svn.apache.org/viewvc?rev=433483&view=rev
> > Log:
> > fix for DIRSERVER-630
> >
> > Added:
> >     directory/branches/apacheds/1.0/server-unit/src/test/java/org/apache/directory/server/IllegalModificationITest.java
> >       - copied, changed from r433475, directory/branches/apacheds/1.0/server-unit/src/test/java/org/apache/directory/server/IllegalModification.java
> > Removed:
> >     directory/branches/apacheds/1.0/server-unit/src/test/java/org/apache/directory/server/IllegalModification.java
> > Modified:
> >     directory/branches/apacheds/1.0/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java
> >
> > Modified: directory/branches/apacheds/1.0/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java
> > URL: http://svn.apache.org/viewvc/directory/branches/apacheds/1.0/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java?rev=433483&r1=433482&r2=433483&view=diff
> > ==============================================================================
> > --- directory/branches/apacheds/1.0/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java (original)
> > +++ directory/branches/apacheds/1.0/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java Mon Aug 21 20:18:05 2006
> > @@ -786,6 +786,17 @@
> >              {
> >                  objectClassMod = mods[ii];
> >              }
> > +
> > +            // Freak out under some weird cases
> > +            if ( mods[0].getAttribute().size() == 0 )
> > +            {
> > +                // not ok for add but ok for replace and delete
> > +                if ( mods[0].getModificationOp() == DirContext.ADD_ATTRIBUTE )
> > +                {
> > +                    throw new LdapInvalidAttributeValueException( "No value is not a valid value for an attribute.",
> > +                        ResultCodeEnum.INVALIDATTRIBUTESYNTAX );
> > +                }
> > +            }
> >
> >              StringBuffer keybuf = new StringBuffer();
> >              keybuf.append( mods[ii].getModificationOp() );
> >
>
> Alex,

Well,

> 1. I think the index used for mods[0].get... portions should be ii instead of 0.

Here is the test case to show that there is still an issue as
mentioned in this item:

http://svn.apache.org/viewvc?view=rev&revision=433577

> 2. What about the other modify method in the schema service?

And here is another about this item:

http://svn.apache.org/viewvc?view=rev&revision=433578

-- 
Ersin