Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 90439 invoked from network); 22 Aug 2006 12:53:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 Aug 2006 12:53:50 -0000 Received: (qmail 44961 invoked by uid 500); 22 Aug 2006 12:53:49 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 44918 invoked by uid 500); 22 Aug 2006 12:53:49 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 44907 invoked by uid 99); 22 Aug 2006 12:53:49 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2006 05:53:49 -0700 X-ASF-Spam-Status: No, hits=1.9 required=10.0 tests=DNS_FROM_RFC_ABUSE,DNS_FROM_RFC_POST,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of aok123@bellsouth.net designates 205.152.59.72 as permitted sender) Received: from [205.152.59.72] (HELO imf24aec.mail.bellsouth.net) (205.152.59.72) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Aug 2006 05:53:47 -0700 Received: from ibm68aec.bellsouth.net ([65.80.200.112]) by imf24aec.mail.bellsouth.net with ESMTP id <20060822125325.PWDX11241.imf24aec.mail.bellsouth.net@ibm68aec.bellsouth.net> for ; Tue, 22 Aug 2006 08:53:25 -0400 Received: from [172.16.1.7] (really [65.80.200.112]) by ibm68aec.bellsouth.net with ESMTP id <20060822125325.HXIA19605.ibm68aec.bellsouth.net@[172.16.1.7]> for ; Tue, 22 Aug 2006 08:53:25 -0400 Message-ID: <44EAFEC9.4000108@bellsouth.net> Date: Tue, 22 Aug 2006 08:55:37 -0400 From: Alex Karasulu User-Agent: Thunderbird 1.5.0.5 (X11/20060728) MIME-Version: 1.0 To: Apache Directory Developers List Subject: Re: svn commit: r433483 - in /directory/branches/apacheds/1.0: core/src/main/java/org/apache/directory/server/core/schema/ server-unit/src/test/java/org/apache/directory/server/ References: <20060822031807.0FC2C1A981A@eris.apache.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Ersin Er wrote: > On 8/22/06, akarasulu@apache.org wrote: >> Author: akarasulu >> Date: Mon Aug 21 20:18:05 2006 >> New Revision: 433483 >> >> URL: http://svn.apache.org/viewvc?rev=433483&view=rev >> Log: >> fix for DIRSERVER-630 >> >> Added: >> >> directory/branches/apacheds/1.0/server-unit/src/test/java/org/apache/directory/server/IllegalModificationITest.java >> >> - copied, changed from r433475, >> directory/branches/apacheds/1.0/server-unit/src/test/java/org/apache/directory/server/IllegalModification.java >> >> Removed: >> >> directory/branches/apacheds/1.0/server-unit/src/test/java/org/apache/directory/server/IllegalModification.java >> >> Modified: >> >> directory/branches/apacheds/1.0/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java >> >> >> Modified: >> directory/branches/apacheds/1.0/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java >> >> URL: >> http://svn.apache.org/viewvc/directory/branches/apacheds/1.0/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java?rev=433483&r1=433482&r2=433483&view=diff >> >> ============================================================================== >> >> --- >> directory/branches/apacheds/1.0/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java >> (original) >> +++ >> directory/branches/apacheds/1.0/core/src/main/java/org/apache/directory/server/core/schema/SchemaService.java >> Mon Aug 21 20:18:05 2006 >> @@ -786,6 +786,17 @@ >> { >> objectClassMod = mods[ii]; >> } >> + >> + // Freak out under some weird cases >> + if ( mods[0].getAttribute().size() == 0 ) >> + { >> + // not ok for add but ok for replace and delete >> + if ( mods[0].getModificationOp() == >> DirContext.ADD_ATTRIBUTE ) >> + { >> + throw new LdapInvalidAttributeValueException( "No >> value is not a valid value for an attribute.", >> + ResultCodeEnum.INVALIDATTRIBUTESYNTAX ); >> + } >> + } >> >> StringBuffer keybuf = new StringBuffer(); >> keybuf.append( mods[ii].getModificationOp() ); >> > > Alex, > > 1. I think the index used for mods[0].get... portions should be ii > instead of 0. > 2. What about the other modify method in the schema service? > Man I was sleeping. Sorry about this. Thanks for the corrections. Alex