directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Trustin Lee" <trus...@gmail.com>
Subject Re: mina-core: VmPipeConnector and AnonymousSocketAddress
Date Mon, 07 Aug 2006 03:31:05 GMT
Hi Steven,

On 8/5/06, steven.x.shaw@jpmorgan.com <steven.x.shaw@jpmorgan.com> wrote:
>
>
> Hi there, I've been using the VmPipeConnector for "unit" testing and have
> come up against a problem. The the AnonymousSocketAddresses that are handed
> out are all the very same instance. The code relies on each client-side
> socket being unique and providing a unique name via toString(). For an
> InetSocketAddress, the toString() returns ip-address/host and port.
>
> I have a small patch for your consideration. Let me know if it's the wrong
> format etc. I haven't been able to run this up against the unit tests for
> mina-core as mvn isn't working for me. mvn doesn't seem to be able to find
> the jar plugin (org.apache.maven.plugins:maven-jar-plugin:pom:2.1-SNAPSHOT)
> so please be aware of that. If anyone know how to get around that problem,
> I'd love to hear about it!
>
> I did write a quick shell script to compile and jar mina-core in order to
> test against my own unit tests and found that it fixes my problem.
>

Your patch looks OK, and thank you for your contribution! :)
Could you create a JIRA issue and attach the patch file to clear a legal
issue?

Thank you in advance,
Trustin
-- 
what we call human nature is actually human habit
--
http://gleamynode.net/
--
PGP key fingerprints:
* E167 E6AF E73A CBCE EE41  4A29 544D DE48 FE95 4E7E
* B693 628E 6047 4F8F CFA4  455E 1C62 A7DC 0255 ECA6

Mime
View raw message