directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Karasulu <aok...@bellsouth.net>
Subject Re: svn commit: r429554 - in /directory/trunks/apacheds: core/src/main/java/org/apache/directory/server/core/exception/ core/src/main/java/org/apache/directory/server/core/schema/ server-unit/src/test/java/org/apache/directory/server/
Date Tue, 08 Aug 2006 12:59:39 GMT
Jörg Henne wrote:
> Alex Karasulu schrieb:
>>
>> Hmmmm the exception service checks with the backend to see if an entry 
>> exists in it.  Basically we need to tell it not to do this for the 
>> schemaSubentry since it is a special virtual entry.  I'll have to look 
>> at the patch to see how you did this.  Did the integration tests pass 
>> when you ran them after making this change?
> I let SchemaService override hasEntry(). I did not try the integration 
> test, though. How do I do that again?

Try running this at the top level apacheds directory to run these tests:

mvn -Dintegration test


>>> - I stored the subschemaSubentry LdapDN in its normalized form, which 
>>> allowed me to compare the two LdapDNs simply with .equals(). This 
>>> saves a few string concatenations with the corresponding garbage. 
>>> This may not amount to much, but I've seen the quoted idiom quite a 
>>> few times and all such optimizations might really add up.
>>
>> Right good thinking!  I thought I did this too.  That way you don't 
>> have to normalize every time.  Basically the interceptor builds the 
>> normalized LdapDN for the schema subentry in the init() method.
>>
>> NOTE: the toNormaName() maintains a cached String of the normalized 
>> name in the LdapDN.
> Sorry, I missed that one. This way the comparison is efficient, of course.

NP at all.

Alex


Mime
View raw message