directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Lecharny (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (DIRSERVER-723) Possible double add of extensibleMatchFilter in filter tree
Date Wed, 30 Aug 2006 00:18:23 GMT
     [ http://issues.apache.org/jira/browse/DIRSERVER-723?page=all ]

Emmanuel Lecharny resolved DIRSERVER-723.
-----------------------------------------

    Resolution: Fixed

Whaoo !!! What a bug !

Thanks a lot for the find, I could have spend hours trying to find it later !

Fixed, the code has been removed.

> Possible double add of extensibleMatchFilter in filter tree
> -----------------------------------------------------------
>
>                 Key: DIRSERVER-723
>                 URL: http://issues.apache.org/jira/browse/DIRSERVER-723
>             Project: Directory ApacheDS
>          Issue Type: Bug
>          Components: ldap
>            Reporter: Pierre-Arnaud Marcelot
>         Assigned To: Emmanuel Lecharny
>
> In internal class "GrammarAction("Init extensible match Filter" )" (line 97), I think
that the extensibleMatchFilter may be added twice in the Filter tree.
> The following code add the Filter :
> ------------------
> // Get the parent, if any
>                     Filter currentFilter = searchRequest.getCurrentFilter();
>                     if ( currentFilter != null )
>                     {
>                         // Ok, we have a parent. The new Filter will be added to
>                         // this parent, then.
>                         ( ( ConnectorFilter ) currentFilter ).addFilter( extensibleMatchFilter
);
>                         extensibleMatchFilter.setParent( currentFilter );
>                     }
>                     else
>                     {
>                         // No parent. This Filter will become the root.
>                         searchRequest.setFilter( extensibleMatchFilter );
>                         extensibleMatchFilter.setParent( searchRequest );
>                     }
> ------------------
> and then, the addCurrentFilter( extensibleMatchFilter ) method is called and does the
same thing another time.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message