directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Karasulu (JIRA)" <j...@apache.org>
Subject [jira] Created: (DIRSERVER-677) Refactor interceptors so only one SearchRequestFilteringEnumeration is used
Date Thu, 20 Jul 2006 04:13:13 GMT
Refactor interceptors so only one SearchRequestFilteringEnumeration is used
---------------------------------------------------------------------------

                 Key: DIRSERVER-677
                 URL: http://issues.apache.org/jira/browse/DIRSERVER-677
             Project: Directory ApacheDS
          Issue Type: Improvement
          Components: core
    Affects Versions: pre-1.0, 1.0-RC1, 1.0-RC2, 1.0-RC3
            Reporter: Alex Karasulu
            Priority: Trivial


We need to clean up the number of nested (wrappings of) SearchResultFilteringEnumerations.
 It's best if we relocate the code that wraps Partition specific Enumerations with this into
the Nexus.  There we can add Filters to a single SearchResultFilteringEnumeration.  Right
now a few interceptors wrap 3 layers of SearchResultFilteringEnumerations.  Here are the offending
interceptors:

(1) DefaultAuthorizationService
(2) SubentryService
(3) CollectiveAttributeService

Creating a new SearchResultFilteringEnumeration everytime costs us about 2% total of processing
time in search operations.  We could save a total of 4% and improve the code.

Regarding addFilter usage
------------------------------------------

Note that some interceptors, these 3, need to add filters at searh construction time rather
than at interceptor service init time.  These services can use the addFilter() interface of
the SearchResultFilteringEnumeration but this interface must make sure the first prefetched
entry is evaluated otherwise the first entry will be returned even if your filter rejects
it.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message