directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marc DeXeT (JIRA)" <j...@apache.org>
Subject [jira] Created: (DIRSERVER-577) Loosen LdapProtocolProvider-ServerLdapContext coupling.
Date Tue, 14 Feb 2006 09:59:08 GMT
Loosen LdapProtocolProvider-ServerLdapContext coupling.
-------------------------------------------------------

         Key: DIRSERVER-577
         URL: http://issues.apache.org/jira/browse/DIRSERVER-577
     Project: Directory ApacheDS
        Type: Improvement
  Components: ldap  
    Versions: 1.0-RC1    
    Reporter: Marc DeXeT
    Priority: Minor


LdapProtocoleProvider is heavely coupled to ServerLdapContext, even the package name has changed
to 'server'.
To allow more custom override, I suggest to do 'instanceof' test at least on LdapContext.lookup("")
result.

You can see such direct casting into SessionRegistry
/.../
else if ( ctx != null && allowAnonymous )
        {
            ServerLdapContext slc = null;
            if ( ! ( ctx instanceof ServerLdapContext ) )
            {
                slc = ( ServerLdapContext ) ctx.lookup( "" );
            }
            else
            {
                slc = ( ServerLdapContext ) ctx;
            }
/.../


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message