directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Norbert Reilly (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRSERVER-583) org.apache.ldap.common.message.SearchRequestImpl needs to implement toString()
Date Tue, 21 Feb 2006 02:14:27 GMT
    [ http://issues.apache.org/jira/browse/DIRSERVER-583?page=comments#action_12367118 ] 

Norbert Reilly commented on DIRSERVER-583:
------------------------------------------

Here is a method implementation which I think should do the trick :


    public String toString()
    {
        StringBuffer    sb = new StringBuffer();

        sb.append( "    SearchRequest\n" );
        sb.append( super.toString() );
        sb.append( "        baseDn : '" ).append(baseDn).append("'\n");
        sb.append( "        filter : '" );
        filter.printToBuffer(sb);
        sb.append("'\n");
        sb.append( "        scope : " ).append(scope.toString()).append('\n');
        sb.append( "        typesOnly : " ).append(typesOnly).append('\n');
        sb.append( "        sizeLimit : " ).append(sizeLimit).append('\n');
        sb.append( "        timeLimit : " ).append(timeLimit).append('\n');
        sb.append( "        derefAliases : " ).append(derefAliases).append('\n');
        sb.append( "        attributes : " );

        boolean         first = true;

        for (Iterator it = attributes.iterator(); it.hasNext();)
        {
            final String    s = (String)it.next();

            if (!first)
                sb.append(", ");
            sb.append('\'').append(s).append('\'');
        }
        sb.append('\n');

        return sb.toString();
    }

> org.apache.ldap.common.message.SearchRequestImpl needs to implement toString()
> ------------------------------------------------------------------------------
>
>          Key: DIRSERVER-583
>          URL: http://issues.apache.org/jira/browse/DIRSERVER-583
>      Project: Directory ApacheDS
>         Type: Bug
>   Components: ldap
>     Versions: 1.0-RC1
>  Environment: N/A
>     Reporter: Norbert Reilly

>
> The other message classes implement friendly toString()s, but the search request doesn't
meaning the default INFO level is of very little use for debugging. I set the priority as
major because this severely impacts debugging system behaviour, and certainly will be noticed
by new users installing RC1 (and may prevent them for providing the raw material to help in
raising JIRA issues).
> Some example output (notice the RECEIVED message is a generic java.lang.Object.toString()):
> [21/02/2006 11:06:42] [/155.35.171.101:2351] SENT:     BindResponse
>         Ldap Result
>             Result code : (ResultCodeEnum[SUCCESS=0]) success
>             Matched DN : 'null'
>             Error message : 'null'
> [21/02/2006 11:06:42] [/155.35.171.101:2351] RECEIVED: org.apache.ldap.common.message.SearchRequestImpl@132ae7
> [21/02/2006 11:06:42] [/155.35.171.101:2351] WRITE:     Search Result Entry
>         Object Name : 'cn=ETA1,dc=example,dc=com'
>         Attributes
> Attributes

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message