Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Received-SPF: pass (asf.osuosl.org: domain of trustin@gmail.com designates
 64.233.184.196 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=IfAqh4NBXlTfJQhmDKQE1p5k9cIZssBw0jV6gHgaQsZIKtKFLxM6cCCby799FlaFBsZnXJxx6PgAsNuBRc/q2HE3uASdO/GzNICEmXwjp4qDMdqXkDuMmkQztSZz3L39dWmZguFd735O+Ls7AryOLfrOCkn1XDLHW3bp9q0r9aA=
Message-ID: <768dcb2e0511170534r51d78d18p@mail.gmail.com>
Date: Thu, 17 Nov 2005 22:34:02 +0900
From: Trustin Lee <trustin@gmail.com>
To: Apache Directory Developers List <dev@directory.apache.org>
Subject: Re: [jira] Commented: (DIRMINA-121) Per-port filter chain
In-Reply-To: 
 <75CFC296F70A08409390004F30EF9B850696841E@uk-ex001.groupinfra.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_32878_18704046.1132234442390"
References: <75CFC296F70A08409390004F30EF9B850696841E@uk-ex001.groupinfra.com>

------=_Part_32878_18704046.1132234442390
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

2005/11/17, Irving, Dave <dave.irving@logicacmg.com>:

> IoFilter.init(IoFilterChain parent, NextFilter nextFilter) does make
> sense if you want your init to fire an event.


I thought IoFilter.init(IoFilterchain, NextFilter, IoSession) makes sense
instead. Am I missing something? :)

Filters would never be inited until a session comes along.
> My proposal does have a problem though: A shared (acceptor / port)
> filter would only be inited / destroyed once (not per session) because
> it's the NextFilter that contains the smarts (not the filter).
> It means that per session init / destroy logic should come in
> "sessionCreated" / "sessionDestroyed" and not "init".
> "init" / "destroy" would be used for initialisation / tear-down of the
> filter itself (e.g. acquiring / releasing resources).


I think we should delay calling init() or destroy() when it is added to
per-manager or per-port chain at the moment to when it is copied to
per-session chain. So we can think per-manager or per-port chain is just an
*inactive* chain that provides data structure only. And I don't see any
reason to call init() in manager/port level if it works only for session.

WDYT?

Trustin
--
what we call human nature is actually human habit
--
http://gleamynode.net/

------=_Part_32878_18704046.1132234442390
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

<br><div><span class=3D"gmail_quote">2005/11/17, Irving, Dave &lt;<a href=
=3D"mailto:dave.irving@logicacmg.com">dave.irving@logicacmg.com</a>&gt;:</s=
pan><br><blockquote class=3D"gmail_quote" style=3D"border-left: 1px solid r=
gb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
IoFilter.init(IoFilterChain parent, NextFilter nextFilter) does make<br>sen=
se if you want your init to fire an event.</blockquote><div><br>I thought I=
oFilter.init(IoFilterchain, NextFilter, IoSession) makes sense instead.&nbs=
p; Am I missing something? :)=20
<br></div><br><blockquote class=3D"gmail_quote" style=3D"border-left: 1px s=
olid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Fil=
ters would never be inited until a session comes along.<br>My proposal does=
 have a problem though: A shared (acceptor / port)
<br>filter would only be inited / destroyed once (not per session) because<=
br>it's the NextFilter that contains the smarts (not the filter).<br>It mea=
ns that per session init / destroy logic should come in<br>&quot;sessionCre=
ated&quot; / &quot;sessionDestroyed&quot; and not &quot;init&quot;.
<br>&quot;init&quot; / &quot;destroy&quot; would be used for initialisation=
 / tear-down of the<br>filter itself (e.g. acquiring / releasing resources)=
.</blockquote><div><br>I think we should delay calling init() or destroy() =
when it is added to per-manager or per-port chain at the moment to when it =
is copied to per-session chain.&nbsp; So we can think per-manager or per-po=
rt chain is just an *inactive* chain that provides data structure only.&nbs=
p; And I don't see any reason to call init() in manager/port level if it wo=
rks only for session.
<br></div></div><br>WDYT?<br><br>Trustin<br>-- <br>what we call human natur=
e is actually human habit<br>--<br><a href=3D"http://gleamynode.net/">http:=
//gleamynode.net/</a>

------=_Part_32878_18704046.1132234442390--