Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 51667 invoked from network); 12 Nov 2005 17:47:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 12 Nov 2005 17:47:19 -0000 Received: (qmail 28073 invoked by uid 500); 12 Nov 2005 17:47:09 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 28024 invoked by uid 500); 12 Nov 2005 17:47:09 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 28012 invoked by uid 99); 12 Nov 2005 17:47:09 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Nov 2005 09:47:09 -0800 X-ASF-Spam-Status: No, hits=2.3 required=10.0 tests=DNS_FROM_RFC_POST,INFO_TLD,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of aok123@bellsouth.net designates 205.152.59.73 as permitted sender) Received: from [205.152.59.73] (HELO imf25aec.mail.bellsouth.net) (205.152.59.73) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Nov 2005 09:47:01 -0800 Received: from ibm69aec.bellsouth.net ([65.80.200.112]) by imf25aec.mail.bellsouth.net with ESMTP id <20051112174647.SPQQ28474.imf25aec.mail.bellsouth.net@ibm69aec.bellsouth.net> for ; Sat, 12 Nov 2005 12:46:47 -0500 Received: from [172.16.1.39] (really [65.80.200.112]) by ibm69aec.bellsouth.net with ESMTP id <20051112174647.NJII9366.ibm69aec.bellsouth.net@[172.16.1.39]> for ; Sat, 12 Nov 2005 12:46:47 -0500 Message-ID: <43762A85.3090906@bellsouth.net> Date: Sat, 12 Nov 2005 12:46:45 -0500 From: Alex Karasulu User-Agent: Mozilla Thunderbird 1.0.7 (Macintosh/20050923) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Apache Directory Developers List Subject: Re: Logging and Logger Name Conventions References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Simon.Temple@saaconsultants.com wrote: > > >I have a couple of points on the use of Loggers I'd like opinions on: > >1. After embedding the server within JBoss it took a long time to stop the >BERDigester DEBUG messages filling up our log files. By convention most >projects that use logging create loggers using their class names: >LoggerFactory.getLogger( InterceptorChainTest.class ); So controlling >logging system wide is quite intuitive. > > > You're right this should be as you say. I have committed a change to make it so: revision 332800 >The BERDIgester does not follow this convention. It creates a logger with >a fixes name "BERDigester". > > org.apache.asn1.ber.digester.BERDigesterLoggingMonitor > >Can/should this be changed? > > > Done above. >2. I spotted a few calls to log.xxx() which are not wrapped in >log.isxxxEnabled() calls. This can lead to inefficiencies especially when >the log.xxx() call involves String concatenation. See >org.apache.ldap.server.jndi.ServerContextFactory log.info() calls for >examples. Can these be changed? > > > Sure Simon you are 100% right. I don't think anyone has made it a good practice to wrap these things. I will make sure I do this all the time. I will accept and apply any patches that wrap log called with a conditional to see if the log level is enabled. I will apply it immediate if you or anyone else can provide them. Thanks, Alex