From dev-return-8918-apmail-directory-dev-archive=directory.apache.org@directory.apache.org Wed Nov 02 20:43:32 2005 Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 59145 invoked from network); 2 Nov 2005 20:43:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 2 Nov 2005 20:43:31 -0000 Received: (qmail 43252 invoked by uid 500); 2 Nov 2005 20:43:30 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 43207 invoked by uid 500); 2 Nov 2005 20:43:30 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 43185 invoked by uid 99); 2 Nov 2005 20:43:29 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2005 12:43:29 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [217.70.33.37] (HELO lists.levonline.com) (217.70.33.37) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2005 12:43:25 -0800 Received: from localhost (lists.levonline.com [127.0.0.1]) by lists.levonline.com (Postfix) with ESMTP id 26376D01B8 for ; Wed, 2 Nov 2005 21:43:08 +0100 (CET) Received: from lists.levonline.com ([127.0.0.1]) by localhost (lists.levonline.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 13281-06 for ; Wed, 2 Nov 2005 21:43:07 +0100 (CET) Received: from ormen4.basenet.levonline.com (ormen4.levonline.com [217.70.32.124]) by lists.levonline.com (Postfix) with ESMTP id 8EFE9D0183 for ; Wed, 2 Nov 2005 21:43:06 +0100 (CET) Received: from [192.168.0.138] (1-1-2-45a.gan.gbg.bostream.se [82.182.102.93]) (authenticated bits=0) by ormen4.basenet.levonline.com (8.12.11/8.12.11) with ESMTP id jA2Kh6Ba030555 for ; Wed, 2 Nov 2005 21:43:06 +0100 Message-ID: <436924F2.7010005@trillian.se> Date: Wed, 02 Nov 2005 21:43:30 +0100 From: Niklas Therning User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051013) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Apache Directory Developers List Subject: [mina] Problem with BlacklistFilter X-Enigmail-Version: 0.92.1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: By http://levonline.com - free virus scanning for all customers X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N I think the BlacklistFilter should implement all of the upstream IoFilter callbacks, not just sessionCreated(), to prevent those events to be propagated to the IoHandler. I have a situation where messageReceived() is called in my IoHandler even if BlacklistFilter has blocked the client. I guess it's because it takes some time for the CloseRequest to be picked up by SocketIoProcessor. If we don't want to call BlacklistFilter.isBlocked(IoSession) for every upstream event we could instead add an attribute to the session in BlacklistFilter.sessionCreated() which tells whether the connection is blocked or not and use that attribute in all the other events. WDYT? /Niklas