directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Trustin Lee <trus...@gmail.com>
Subject Re: [mina] Problem with BlacklistFilter
Date Thu, 03 Nov 2005 00:44:25 GMT
Ah I see. I'll fix that now.

2005/11/3, Niklas Therning <niklas@trillian.se>:
>
> I think the BlacklistFilter should implement all of the upstream
> IoFilter callbacks, not just sessionCreated(), to prevent those events
> to be propagated to the IoHandler. I have a situation where
> messageReceived() is called in my IoHandler even if BlacklistFilter has
> blocked the client. I guess it's because it takes some time for the
> CloseRequest to be picked up by SocketIoProcessor.
>
> If we don't want to call BlacklistFilter.isBlocked(IoSession) for every
> upstream event we could instead add an attribute to the session in
> BlacklistFilter.sessionCreated() which tells whether the connection is
> blocked or not and use that attribute in all the other events.
>
> WDYT?
>
> /Niklas
>
>


--
what we call human nature is actually human habit
--
http://gleamynode.net/

Mime
View raw message