directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Trustin Lee (JIRA)" <j...@apache.org>
Subject [jira] Closed: (DIRMINA-94) Get rid of ProtocolViolationException.getBuffer()
Date Mon, 17 Oct 2005 08:27:44 GMT
     [ http://issues.apache.org/jira/browse/DIRMINA-94?page=all ]
     
Trustin Lee closed DIRMINA-94:
------------------------------

    Resolution: Fixed

* Replaced get/setBuffer() with get/setHexdump(String dumpstr)
* Now all input buffers are released properly even in case of ProtocolViolation.

> Get rid of ProtocolViolationException.getBuffer()
> -------------------------------------------------
>
>          Key: DIRMINA-94
>          URL: http://issues.apache.org/jira/browse/DIRMINA-94
>      Project: Directory MINA
>         Type: Task
>     Reporter: Trustin Lee
>     Assignee: Trustin Lee
>     Priority: Minor
>      Fix For: 0.8

>
> As I specified DIRMINA-91 currently prevents all ByteBuffers that violates the protocol
specification from being returned to the buffer pool.  This can cause performance degradation
of server by malicious user.  So I think it'd be better to get rid of getBuffer() method from
ProtocolViolationException and just provide a pretty HEX dump.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message