directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Trustin Lee (JIRA)" <directory-...@incubator.apache.org>
Subject [jira] Closed: (DIREVE-164) Refactor ExceptionService and move integrity check code to Database.
Date Tue, 25 Oct 2005 08:35:02 GMT
     [ http://issues.apache.org/jira/browse/DIREVE-164?page=all ]
     
Trustin Lee closed DIREVE-164:
------------------------------

    Resolution: Invalid

I've found our implementation (apacheds-core) throws an LdapNamingException with LDAP-specific
error codes such as ALIASPROBLEM.  I thought we can stop all classes from throwing LdapNamingException
and make them throw NamingException instead, and then ExceptionService can convert them to
corresponding LdapNamingExceptions 1:1.  But it's not 1:1 right now.  So I cannot divide ExceptionService
into IntegrityService and ExceptionService logically.

I guess we need to standardize which type of exceptions we should throw for consistency. 
NamingException or LdapNamingException?  I think LdapNamingException is the way to go.

> Refactor ExceptionService and move integrity check code to Database.
> --------------------------------------------------------------------
>
>          Key: DIREVE-164
>          URL: http://issues.apache.org/jira/browse/DIREVE-164
>      Project: Directory Server
>         Type: Improvement
>   Components: interceptors
>     Reporter: Trustin Lee
>     Assignee: Trustin Lee
>      Fix For: 0.9.3

>
> The original duty of ExceptionService was to convert JNDI exceptions and other exceptions
to LDAP exceptions, but now it is doing more than its duty; it is checking exsitance of entries,
etc.
> So my idea is to move those integrity check code to Database implementation (or its abstract
parent?)  We'll also need good documentation about how to implement Database.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message