Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 29855 invoked from network); 14 Sep 2005 11:20:58 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 14 Sep 2005 11:20:58 -0000 Received: (qmail 69273 invoked by uid 500); 14 Sep 2005 11:20:57 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 69224 invoked by uid 500); 14 Sep 2005 11:20:57 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 69211 invoked by uid 99); 14 Sep 2005 11:20:56 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=SPF_FAIL X-Spam-Check-By: apache.org Received: from [192.87.106.226] (HELO ajax.apache.org) (192.87.106.226) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Sep 2005 04:20:56 -0700 Received: from ajax.apache.org (ajax.apache.org [127.0.0.1]) by ajax.apache.org (Postfix) with ESMTP id 115A0138 for ; Wed, 14 Sep 2005 13:20:55 +0200 (CEST) Message-ID: <2023290220.1126696855069.JavaMail.jira@ajax.apache.org> Date: Wed, 14 Sep 2005 13:20:55 +0200 (CEST) From: "Trustin Lee (JIRA)" To: dev@directory.apache.org Subject: [jira] Commented: (DIR-112) The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP. In-Reply-To: <1083144118.1118764848219.JavaMail.jira@ajax.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/DIR-112?page=comments#action_12324520 ] Trustin Lee commented on DIR-112: --------------------------------- Alex, does your fix include changes in ContextPartition.getSuffix( boolean )? It should be reopen if it doesn't. > The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP. > ------------------------------------------------------------------------------------- > > Key: DIR-112 > URL: http://issues.apache.org/jira/browse/DIR-112 > Project: Directory > Type: Bug > Components: General > Reporter: Jacob S. Barrett > Assignee: Alex Karasulu > Priority: Critical > Attachments: NameTest.java, NameTest.java, NameTest.java, name-prefix-suffix.patch > > The attached patch fixes the LdapName#getSuffix(int) method to match the one on Java 1.5. The current getSuffix returns a prefix of sorts, but not exactly that of getPrefix. This patch also contains fixes for all (hopefully) places where getSuffix(int) was called. It also corrects the JUnit test. I have also attached a JUnit test that must be compiled and run under Java 1.5 to make sure the naming classes behave the same as Java 1.5's version. > This patch does NOT change the ContextPartion's concet of suffix even though it is really a prefix. So it is called a suffix still, but it is really the prefix. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira