directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jacob Barrett" <Jaco...@attachmatewrq.com>
Subject RE: [jira] Commented: (DIR-112) The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
Date Wed, 14 Sep 2005 14:48:19 GMT
In all actuality shouldn't that method be renamed getPrefix since it is
actually the prefix that is returned? 

> -----Original Message-----
> From: Trustin Lee (JIRA) [mailto:directory-dev@incubator.apache.org] 
> Sent: Wednesday, September 14, 2005 4:21 AM
> To: Jacob Barrett
> Subject: [jira] Commented: (DIR-112) The implementation of 
> LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
> 
>     [ 
> http://issues.apache.org/jira/browse/DIR-112?page=comments#act
> ion_12324520 ] 
> 
> Trustin Lee commented on DIR-112:
> ---------------------------------
> 
> Alex, does your fix include changes in 
> ContextPartition.getSuffix( boolean )?  It should be reopen 
> if it doesn't.
> 
> > The implementation of LdapName#getSuffix(int) does not 
> match that of Java 1.5's LDAP.
> > 
> ----------------------------------------------------------------------
> > ---------------
> >
> >          Key: DIR-112
> >          URL: http://issues.apache.org/jira/browse/DIR-112
> >      Project: Directory
> >         Type: Bug
> >   Components: General
> >     Reporter: Jacob S. Barrett
> >     Assignee: Alex Karasulu
> >     Priority: Critical
> >  Attachments: NameTest.java, NameTest.java, NameTest.java, 
> > name-prefix-suffix.patch
> >
> > The attached patch fixes the LdapName#getSuffix(int) method 
> to match the one on Java 1.5.  The current getSuffix returns 
> a prefix of sorts, but not exactly that of getPrefix.  This 
> patch also contains fixes for all (hopefully) places where 
> getSuffix(int) was called.  It also corrects the JUnit test.  
> I have also attached a JUnit test that must be compiled and 
> run under Java 1.5 to make sure the naming classes behave the 
> same as Java 1.5's version.
> > This patch does NOT change the ContextPartion's concet of 
> suffix even though it is really a prefix.  So it is called a 
> suffix still, but it is really the prefix.
> 
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the 
> administrators:
>    http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
>    http://www.atlassian.com/software/jira
> 
> 

Mime
View raw message