directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Karasulu (JIRA)" <>
Subject [jira] Commented: (DIRLDAP-53) "LDAP ACIItem" Parser Implementation
Date Wed, 14 Sep 2005 15:44:59 GMT
    [ ] 

Alex Karasulu commented on DIRLDAP-53:

Dude this is an awesome patch.  I cannot express how difficult the ASN.1 interpretation of
the ACIItem must have been into an antlr LL(1) grammar.  This is a great job and a great patch
as I can see after reviewing it.  I will apply it now.

Thank you for being so thorough.  

> "LDAP ACIItem" Parser Implementation
> ------------------------------------
>          Key: DIRLDAP-53
>          URL:
>      Project: Directory LDAP
>         Type: New Feature
>   Components: Common
>     Versions: 0.9.3
>     Reporter: Ersin Er
>     Priority: Minor
>  Attachments: ACIItemParser_01.patch
> An implementation of ACIItem, ported from X.501 to LDAP, parser is provided as a patch
attached with this issue.
> The implementation includes:
>  - an almost complete "LDAP ACIItem" Antlr grammar
>  - a wrapper around the Antlr generated classes
>  - two auxilary classes for parser/lexer pair reusability
>  - a test class
>  - and a maven configuration update
>  - Good test coverage
>  - Model integration via actions
>  - Cleanup
> ACI is a tough subject and this parser is no exception. This is somewhat a big grammar
that needs extensive testing which is missing now. The current grammar does not integrate
with ACIItem API implemented by Trustin, because we need to discuss some issues about porting
X.501 ACIItem to LDAP and about string representation of some components. After we agree on
a robust spec, I'll update the grammar to fully comply with "our ACIItem spec" (Trustin may
also need to update his stuff). One more step will be integrating with ACIItem API which will
be a one hour task with Trustin's super clear implementation (thanks Trustin!).
> I'll further discuss the issue on the mailing list.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message