Mailing-List: contact dev-help@directory.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Apache Directory Developers List" <dev@directory.apache.org>
Message-ID: <1900007325.1121825328185.JavaMail.jira@ajax.apache.org>
Date: Wed, 20 Jul 2005 04:08:48 +0200 (CEST)
From: "Trustin Lee (JIRA)" <jira@apache.org>
To: dev@directory.apache.org
Subject: [jira] Commented: (DIRMINA-73) The new close(boolean wait) logic
 seems flawed, never waiting for flush
In-Reply-To: <1854784825.1121772107195.JavaMail.jira@ajax.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/DIRMINA-73?page=comments#action_12316194 ] 

Trustin Lee commented on DIRMINA-73:
------------------------------------

Thank you, Magnus!  And I'm sorry for this stupid bug. :)

I'll comment here again after I check in your fix and deploy the 0.7.4-SNAPSHOT jar.

> The new close(boolean wait) logic seems flawed, never waiting for flush
> -----------------------------------------------------------------------
>
>          Key: DIRMINA-73
>          URL: http://issues.apache.org/jira/browse/DIRMINA-73
>      Project: Directory MINA
>         Type: Bug
>     Versions: 0.7.3
>  Environment: N/A
>     Reporter: Magnus Naeslund
>     Assignee: Trustin Lee
>     Priority: Critical
>  Attachments: mina-SocketSession-close-fix1.diff
>
> It seems the while (disposed) test should be inverted.
> Patch:
> --- org/apache/mina/io/socket/SocketSession.java        (revision 219643)
> +++ org/apache/mina/io/socket/SocketSession.java        (working copy)
> @@ -130,7 +130,7 @@
>          SocketIoProcessor.getInstance().removeSession( this );
>          if( wait )
>          {
> -            while( disposed )
> +            while( !disposed )
>              {
>                  try
>                  {

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira