Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 18531 invoked from network); 26 Jun 2005 14:44:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 26 Jun 2005 14:44:52 -0000 Received: (qmail 66783 invoked by uid 500); 26 Jun 2005 14:44:50 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 66742 invoked by uid 500); 26 Jun 2005 14:44:50 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 66729 invoked by uid 99); 26 Jun 2005 14:44:50 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 Jun 2005 07:44:50 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=RCVD_BY_IP X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of nickfaiz@gmail.com designates 64.233.162.199 as permitted sender) Received: from [64.233.162.199] (HELO zproxy.gmail.com) (64.233.162.199) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 Jun 2005 07:44:50 -0700 Received: by zproxy.gmail.com with SMTP id r28so108588nza for ; Sun, 26 Jun 2005 07:44:47 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=kBvkHEhyC3/m6bz0lmuF75N+ti8zQmQAzlQW9fBTHXK6vl4invEK7VDPTPQ6dl00UdMtQgDYTHbuLFyo+oMnHM18LMau0QrxjuC2B/X5FwgZ+le2saWc84SxsblUUehIdvaq3o5KW8q1ZDhC+Ui6YGtJ58alm+jA+cKwSgVkdLI= Received: by 10.36.43.17 with SMTP id q17mr3194050nzq; Sun, 26 Jun 2005 07:44:47 -0700 (PDT) Received: by 10.36.91.14 with HTTP; Sun, 26 Jun 2005 07:44:47 -0700 (PDT) Message-ID: <8a8dec400506260744e686e31@mail.gmail.com> Date: Mon, 27 Jun 2005 00:44:47 +1000 From: nickf Reply-To: nickf To: Apache Directory Developers List Subject: Re: (PATCH) - log4j config for apacheds/main & core In-Reply-To: <42BEBB47.30609@bellsouth.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <8a8dec40050625233251c9e764@mail.gmail.com> <42BEBB47.30609@bellsouth.net> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hey Alex, No prob.s. Please check out http://issues.apache.org/jira/browse/DIREVE-= 171 . Cheers, Nick On 6/27/05, Alex Karasulu wrote: > nickf wrote: >=20 > >Hi, > > I've attached a diff which adds a log4j config to main and core. > >I've also included the log4j.properties . > > > > Modifications include adding a preGoal for the 'jar:jar' goal to > >the maven.xml of each project to ensure that the log4j.properties is > >within the build jar. This preGoal assumes that the log4j.properties > >file can be found in main/src/etc/ and core/src/etc/ . > > > > I've also replaced most sout calls with logging statements. > > > > This is my first svn patch so please let me know if something is inco= rrect. > > > > > Nick this is great thanks! Can you do us a little favor though: Can you > open a JIRA issue and add your patch to the issue as an attachment? >=20 > Thanks, > Alex >