directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Karasulu (JIRA)" <directory-...@incubator.apache.org>
Subject [jira] Commented: (DIR-112) The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
Date Thu, 16 Jun 2005 06:18:53 GMT
    [ http://issues.apache.org/jira/browse/DIR-112?page=comments#action_12313802 ] 

Alex Karasulu commented on DIR-112:
-----------------------------------

Sorry can't apply this (really want to though) because it binds us to 1.5 with the test case.
 All users will have to run builds using the 1.5 jdk.  Can you generate the results of using
the JDK 1.5 LdapName and use them (generated values) as String based expected values?  This
way there is no 1.5 dependency and the compilations will work for everyone ;).


> The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.
> -------------------------------------------------------------------------------------
>
>          Key: DIR-112
>          URL: http://issues.apache.org/jira/browse/DIR-112
>      Project: Directory
>         Type: Bug
>   Components: General
>     Reporter: Jacob S. Barrett
>     Assignee: Alex Karasulu
>     Priority: Critical
>  Attachments: NameTest.java, name-prefix-suffix.patch
>
> The attached patch fixes the LdapName#getSuffix(int) method to match the one on Java
1.5.  The current getSuffix returns a prefix of sorts, but not exactly that of getPrefix.
 This patch also contains fixes for all (hopefully) places where getSuffix(int) was called.
 It also corrects the JUnit test.  I have also attached a JUnit test that must be compiled
and run under Java 1.5 to make sure the naming classes behave the same as Java 1.5's version.
> This patch does NOT change the ContextPartion's concet of suffix even though it is really
a prefix.  So it is called a suffix still, but it is really the prefix.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message