directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Panicker (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DIRMINA-40) Filter API needs callback for enabled notification
Date Tue, 17 May 2005 08:47:06 GMT
     [ http://issues.apache.org/jira/browse/DIRMINA-40?page=comments#action_65590 ]
     
Vinod Panicker commented on DIRMINA-40:
---------------------------------------

Your fix solves the problem.  Thanks.

My rationale behind having filterEnabled() and filterDisabled() was to have something like
a constructor/destructor for a filter.  The filter programmer can do all setup/teardown work
in the respective callbacks.

Even if the filter gets applied to an Acceptor, filterEnabled() would get called only once
for its lifetime and not for each accepted connection.

This helps a lot in having a clean filter implementation IMO.

> Filter API needs callback for enabled notification
> --------------------------------------------------
>
>          Key: DIRMINA-40
>          URL: http://issues.apache.org/jira/browse/DIRMINA-40
>      Project: Directory MINA
>         Type: Improvement
>     Versions: 0.7, 0.7.1
>  Environment: All
>     Reporter: Vinod Panicker
>     Assignee: Trustin Lee
>     Priority: Blocker

>
> The Filter api currently assumes that it would be applied only on unopened sessions.
 Eg - the SSL filter currently starts its work on the sessionOpened() callback.  This is an
incorrect assumption since the SSL filter could be applied on an existing plain TCP connection
as well.
> It would be great if there were new callbacks defined  - something like filterEnabled()
and filterDisabled()
> This would allow us to use the filters on existing sessions as well.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message