Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 1938 invoked from network); 22 Apr 2005 02:52:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 Apr 2005 02:52:04 -0000 Received: (qmail 15636 invoked by uid 500); 22 Apr 2005 02:52:23 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 15593 invoked by uid 500); 22 Apr 2005 02:52:23 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 15580 invoked by uid 99); 22 Apr 2005 02:52:23 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=RCVD_BY_IP X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: domain of trustin@gmail.com designates 64.233.184.200 as permitted sender) Received: from wproxy.gmail.com (HELO wproxy.gmail.com) (64.233.184.200) by apache.org (qpsmtpd/0.28) with ESMTP; Thu, 21 Apr 2005 19:52:23 -0700 Received: by wproxy.gmail.com with SMTP id 70so882313wra for ; Thu, 21 Apr 2005 19:52:01 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=DIX+1to5cT3SpOyD5c1mLDcbZYLXc3MF//smRECmL6RMXBbrmkR01N0ILIxlg121ooHHWlJzELO4XCorr0l1jwvefPEH0CFF2JgpmYnz4+il55yrDmjdXoeoF0xHgJn+WblYoC9Pj9mGx3mYQAqaLs4A1IGwbjrkj0aKH3SNEqA= Received: by 10.54.40.71 with SMTP id n71mr230729wrn; Thu, 21 Apr 2005 19:52:01 -0700 (PDT) Received: by 10.54.70.20 with HTTP; Thu, 21 Apr 2005 19:52:01 -0700 (PDT) Message-ID: <768dcb2e05042119524c28fb71@mail.gmail.com> Date: Fri, 22 Apr 2005 11:52:01 +0900 From: Trustin Lee Reply-To: Trustin Lee To: Apache Directory Developers List Subject: Re: Mina threading In-Reply-To: <1114071767.426762d769979@webmail.daune-consult.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <1113832134.4263bac6c5fc2@webmail.daune-consult.com> <768dcb2e05041808417d17ea27@mail.gmail.com> <42669573.4020503@daune-consult.com> <768dcb2e05042018306d1bc9e9@mail.gmail.com> <1114071767.426762d769979@webmail.daune-consult.com> X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hi, 2005/4/21, daune.jf@daune-consult.com : >=20 > Thanks for clarification, Justin. No problem. >=20 > After having better read the code, I would like to highlight some possibl= e > improvements: >=20 > 1) IoThreadPoolFilter.getPoolSize() and ProtocolThreadPoolFilter.getPoolS= ize() > are synchronized. Synchronizing on poolSizeLock could be used instead. >=20 I fixed it. > 2) IoThreadPoolFilter and ProtocolThreadPoolFilter could implement a comm= on > interface (such as ThreadPoolBased) defining getPoolSize, > get/setMaximumPoolSize and get/setKeepAliveTime. In fact, it is probably > possible to factor out implementation too. >=20 I've just fixed it, too. I added a common interface ThreadPool and implemented most of functionality in BaseThreadPool.=20 IoThreadPoolFilter and ProtocolThreadPoolFilter looks much better. Thanks for pointing it out! Cheers, Trustin --=20 what we call human nature is actually human habit -- http://gleamynode.net/