Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 64295 invoked from network); 22 Apr 2005 06:39:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 Apr 2005 06:39:41 -0000 Received: (qmail 74535 invoked by uid 500); 22 Apr 2005 06:40:00 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 74470 invoked by uid 500); 22 Apr 2005 06:40:00 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 74439 invoked by uid 99); 22 Apr 2005 06:39:59 -0000 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=FORGED_RCVD_HELO,NO_REAL_NAME X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from reversed.easyhost.be (HELO linux.easyhost.be) (193.74.65.221) by apache.org (qpsmtpd/0.28) with ESMTP; Thu, 21 Apr 2005 23:39:59 -0700 Received: (qmail 26002 invoked from network); 22 Apr 2005 06:39:34 -0000 Received: from localhost (127.0.0.1) by localhost with SMTP; 22 Apr 2005 06:39:34 -0000 Received: from 195.0.96.5 ([195.0.96.5]) by webmail.daune-consult.com (IMP) with HTTP for ; Fri, 22 Apr 2005 08:39:34 +0200 Message-ID: <1114151974.42689c269fcfb@webmail.daune-consult.com> Date: Fri, 22 Apr 2005 08:39:34 +0200 From: daune.jf@daune-consult.com To: Apache Directory Developers List , Trustin Lee Subject: Re: Mina threading References: <1113832134.4263bac6c5fc2@webmail.daune-consult.com> <768dcb2e05041808417d17ea27@mail.gmail.com> <42669573.4020503@daune-consult.com> <768dcb2e05042018306d1bc9e9@mail.gmail.com> <1114071767.426762d769979@webmail.daune-consult.com> <768dcb2e05042119524c28fb71@mail.gmail.com> In-Reply-To: <768dcb2e05042119524c28fb71@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit User-Agent: Internet Messaging Program (IMP) 3.2.3 X-Originating-IP: 195.0.96.5 X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Selon Trustin Lee : > > 2) IoThreadPoolFilter and ProtocolThreadPoolFilter could implement a common > > interface (such as ThreadPoolBased) defining getPoolSize, > > get/setMaximumPoolSize and get/setKeepAliveTime. In fact, it is probably > > possible to factor out implementation too. > > > > I've just fixed it, too. I added a common interface ThreadPool and > implemented most of functionality in BaseThreadPool. > IoThreadPoolFilter and ProtocolThreadPoolFilter looks much better. > > Thanks for pointing it out! > Trustin (sorry for the Justin !), don't you think that refactoring could even be pushed further by extracting an implementation of the leader-followers pattern that could be reused ? There is a Jakarta Commons ThreadPool project. This could eventually be moved there. Cheers, J-F ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.