Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 97075 invoked from network); 22 Apr 2005 02:19:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 Apr 2005 02:19:32 -0000 Received: (qmail 75980 invoked by uid 500); 22 Apr 2005 02:19:52 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 75932 invoked by uid 500); 22 Apr 2005 02:19:51 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Delivered-To: moderator for dev@directory.apache.org Received: (qmail 75014 invoked by uid 99); 21 Apr 2005 08:23:03 -0000 X-ASF-Spam-Status: No, hits=0.2 required=10.0 tests=FORGED_RCVD_HELO,NO_REAL_NAME X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Message-ID: <1114071767.426762d769979@webmail.daune-consult.com> Date: Thu, 21 Apr 2005 10:22:47 +0200 From: daune.jf@daune-consult.com To: Apache Directory Developers List Subject: Re: Mina threading References: <1113832134.4263bac6c5fc2@webmail.daune-consult.com> <768dcb2e05041808417d17ea27@mail.gmail.com> <42669573.4020503@daune-consult.com> <768dcb2e05042018306d1bc9e9@mail.gmail.com> In-Reply-To: <768dcb2e05042018306d1bc9e9@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit User-Agent: Internet Messaging Program (IMP) 3.2.3 X-Originating-IP: 195.0.96.5 X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Thanks for clarification, Justin. After having better read the code, I would like to highlight some possible improvements: 1) IoThreadPoolFilter.getPoolSize() and ProtocolThreadPoolFilter.getPoolSize() are synchronized. Synchronizing on poolSizeLock could be used instead. 2) IoThreadPoolFilter and ProtocolThreadPoolFilter could implement a common interface (such as ThreadPoolBased) defining getPoolSize, get/setMaximumPoolSize and get/setKeepAliveTime. In fact, it is probably possible to factor out implementation too. Cheers, J-F ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.