directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Trustin Lee <trus...@gmail.com>
Subject Re: [mina] Filter design issue?
Date Fri, 29 Apr 2005 17:55:46 GMT
Hi Vinod,

2005/4/30, Vinod Panicker <vinod.p@gmail.com>:
<snip/>

> > You can downcast your ProtocolSession to IoProtocolSession and then
> > you can get the backing IoSession so that you can add SSLFilter.  :)
> 
> Missed that.  But IMO, since the ProtocolSession is actually using the
> io package classes, why not have protocol as a sub-package of io?  And
> also a proper inheritance tree that establishes this relationship.
> All protocols are doing io anyways.

There is an in-VM pipe communication which bypasses I/O layer. ;)

> > > Suggestion would be to combine all filters into a common hierarchy and
> > > make them applicable to Session.
> >
> > We can lose type safety, if we do so.  So I didn't do like that
> > intentionally.  WDYT?
> 
> I would still stand by having all filters applicable to sessions.  It
> makes it much easier to use filters for different kind of sessions
> wherever applicable.  IMO a ProtocolSession is nothing but a more
> user-friendly version of IoSession.  Ditto with all Protocolxxx and
> Ioxxx.

In-VM pipe support is a problem here again as you've expected.

Thanks,
Trustin
-- 
what we call human nature is actually human habit
--
http://gleamynode.net/

Mime
View raw message