directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Trustin Lee <trus...@gmail.com>
Subject Re: Mina threading
Date Fri, 22 Apr 2005 02:52:01 GMT
Hi,

2005/4/21, daune.jf@daune-consult.com <daune.jf@daune-consult.com>:
> 
> Thanks for clarification, Justin.

No problem.

> 
> After having better read the code, I would like to highlight some possible
> improvements:
> 
> 1) IoThreadPoolFilter.getPoolSize() and ProtocolThreadPoolFilter.getPoolSize()
> are synchronized. Synchronizing on poolSizeLock could be used instead.
> 

I fixed it.

> 2) IoThreadPoolFilter and ProtocolThreadPoolFilter could implement a common
> interface (such as ThreadPoolBased) defining getPoolSize,
> get/setMaximumPoolSize and get/setKeepAliveTime. In fact, it is probably
> possible to factor out implementation too.
> 

I've just fixed it, too. I added a common interface ThreadPool and
implemented most of functionality in BaseThreadPool. 
IoThreadPoolFilter and ProtocolThreadPoolFilter looks much better.

Thanks for pointing it out!

Cheers,
Trustin
-- 
what we call human nature is actually human habit
--
http://gleamynode.net/

Mime
View raw message