directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daune...@daune-consult.com
Subject Re: Mina threading
Date Fri, 22 Apr 2005 06:39:34 GMT
Selon Trustin Lee <trustin@gmail.com>:

> > 2) IoThreadPoolFilter and ProtocolThreadPoolFilter could implement a common
> > interface (such as ThreadPoolBased) defining getPoolSize,
> > get/setMaximumPoolSize and get/setKeepAliveTime. In fact, it is probably
> > possible to factor out implementation too.
> >
>
> I've just fixed it, too. I added a common interface ThreadPool and
> implemented most of functionality in BaseThreadPool.
> IoThreadPoolFilter and ProtocolThreadPoolFilter looks much better.
>
> Thanks for pointing it out!
>

Trustin (sorry for the Justin !),

don't you think that refactoring could even be pushed further by extracting an
implementation of the leader-followers pattern that could be reused ?

There is a Jakarta Commons ThreadPool project. This could eventually be moved
there.

Cheers,

J-F

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.


Mime
View raw message