directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daune...@daune-consult.com
Subject Re: Mina threading
Date Thu, 21 Apr 2005 08:22:47 GMT

Thanks for clarification, Justin.

After having better read the code, I would like to highlight some possible
improvements:

1) IoThreadPoolFilter.getPoolSize() and ProtocolThreadPoolFilter.getPoolSize()
are synchronized. Synchronizing on poolSizeLock could be used instead.

2) IoThreadPoolFilter and ProtocolThreadPoolFilter could implement a common
interface (such as ThreadPoolBased) defining getPoolSize,
get/setMaximumPoolSize and get/setKeepAliveTime. In fact, it is probably
possible to factor out implementation too.

Cheers,

J-F

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.


Mime
View raw message