Return-Path: Delivered-To: apmail-incubator-directory-dev-archive@www.apache.org Received: (qmail 26541 invoked from network); 11 Mar 2005 17:45:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 11 Mar 2005 17:45:45 -0000 Received: (qmail 22903 invoked by uid 500); 11 Mar 2005 17:45:44 -0000 Delivered-To: apmail-incubator-directory-dev-archive@incubator.apache.org Received: (qmail 22814 invoked by uid 500); 11 Mar 2005 17:45:43 -0000 Mailing-List: contact directory-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list directory-dev@incubator.apache.org Received: (qmail 22800 invoked by uid 99); 11 Mar 2005 17:45:43 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: local policy) Received: from beaver.codehaus.org (HELO codehaus.org) (64.7.141.17) by apache.org (qpsmtpd/0.28) with SMTP; Fri, 11 Mar 2005 09:45:43 -0800 Received: (qmail 28175 invoked from network); 11 Mar 2005 17:45:41 -0000 Received: from adsl-69-229-191-14.dsl.irvnca.pacbell.net (HELO ?172.16.1.35?) (brett@69.229.191.14) by codehaus.org with SMTP; 11 Mar 2005 17:45:41 -0000 Message-ID: <4231D954.7080000@apache.org> Date: Fri, 11 Mar 2005 09:45:56 -0800 From: Brett Porter Reply-To: brett@apache.org User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Apache Directory Developers List Subject: Re: svn commit: r157092 - incubator/directory/network/mina/trunk/project.xml References: <20050311151219.43620.qmail@minotaur.apache.org> <4231B5E5.3080904@bellsouth.net> In-Reply-To: <4231B5E5.3080904@bellsouth.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N I think it's the reverse: you're only excluding those classes in JDK 1.5 with the below. I've never used source modifications - they were tossed in as a quick fix. Even if it is a small library, I think it is preferable to make a separate JAR for these. WDYT? - Brett Alex Karasulu wrote: > Hi Brett, > > Ya know why this might not be working? In JDK 1.4 there is no > SSLEngine class so one would expect these classes to not be included > in the build. However they still are. Is there some property I need > to tweak to make this stick? > > Thanks, > -- Alex > > akarasulu@apache.org wrote: > >> Author: akarasulu >> Date: Fri Mar 11 07:12:15 2005 >> New Revision: 157092 >> >> URL: http://svn.apache.org/viewcvs?view=rev&rev=157092 >> Log: >> These changes are supposed to make it so we can compile MINA fine in >> 1.4 or 1.5 land but it seems to not work for some reason. Basically >> if the SSLEngine >> is not found the classes under excludes will not be included in the >> compile. >> >> NOTE: check with Brett if this feature is still used in Maven 1.0.2 >> >> >> Modified: >> incubator/directory/network/mina/trunk/project.xml >> >> Modified: incubator/directory/network/mina/trunk/project.xml >> URL: >> http://svn.apache.org/viewcvs/incubator/directory/network/mina/trunk/project.xml?view=diff&r1=157091&r2=157092 >> >> ============================================================================== >> >> --- incubator/directory/network/mina/trunk/project.xml (original) >> +++ incubator/directory/network/mina/trunk/project.xml Fri Mar 11 >> 07:12:15 2005 >> @@ -119,6 +119,16 @@ >> >> >> directory-dev@incubator.apache.org >> ${basedir}/src/java >> + >> + >> + javax.net.ssl.SSLEngine >> + >> + **/SSLFilter.java >> + **/SSLHandler.java >> + **/SSLByteBufferPool.java >> + >> + >> + >> >> ${basedir}/src/test >> >> >> >> >> >> >> > >