Return-Path: Delivered-To: apmail-directory-dev-archive@www.apache.org Received: (qmail 72541 invoked from network); 21 Mar 2005 07:03:26 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 21 Mar 2005 07:03:26 -0000 Received: (qmail 31052 invoked by uid 500); 21 Mar 2005 07:03:25 -0000 Delivered-To: apmail-directory-dev-archive@directory.apache.org Received: (qmail 31003 invoked by uid 500); 21 Mar 2005 07:03:25 -0000 Mailing-List: contact dev-help@directory.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list dev@directory.apache.org Received: (qmail 30988 invoked by uid 99); 21 Mar 2005 07:03:25 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from ajax-1.apache.org (HELO ajax.apache.org) (192.87.106.226) by apache.org (qpsmtpd/0.28) with ESMTP; Sun, 20 Mar 2005 23:03:23 -0800 Received: from ajax.apache.org (ajax.apache.org [127.0.0.1]) by ajax.apache.org (8.12.11/8.12.11) with ESMTP id j2L73Kdc026798 for ; Mon, 21 Mar 2005 08:03:20 +0100 Message-ID: <1110318193.1111388600702.JavaMail.jira@ajax.apache.org> Date: Mon, 21 Mar 2005 08:03:20 +0100 (CET) From: "Nikola Ivancevic (JIRA)" To: dev@directory.apache.org Subject: [jira] Commented: (DIREVE-90) (Java 5) append().append() fix, append(char) IOException fix Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/DIREVE-90?page=comments#action_61291 ] Nikola Ivancevic commented on DIREVE-90: ---------------------------------------- Before aspectj reachs 1.5final, is it possible to incorporate (again) the commited patch in apacheds-0.9? Or java1.5 is out of consideration currently? > (Java 5) append().append() fix, append(char) IOException fix > ------------------------------------------------------------ > > Key: DIREVE-90 > URL: http://issues.apache.org/jira/browse/DIREVE-90 > Project: Directory Server > Type: Bug > Environment: Java 5 > Reporter: Mark Swanson > Assignee: Alex Karasulu > > Here is a patch for the mentioned issues: > Index: jndi-provider/src/java/org/apache/eve/jndi/InvocationMethodEnum.java > =================================================================== > --- jndi-provider/src/java/org/apache/eve/jndi/InvocationMethodEnum.java (revision 109245) > +++ jndi-provider/src/java/org/apache/eve/jndi/InvocationMethodEnum.java (working copy) > @@ -305,7 +305,7 @@ > { > StringBuffer buf = new StringBuffer(); > buf.append( method.getName() ); > - buf.append( '(' ); > + buf.append( "(" ); > Class[] params = method.getParameterTypes(); > for ( int ii = 0; ii < params.length; ii++ ) > @@ -314,11 +314,11 @@ > if ( ii < params.length - 1 ) > { > - buf.append( ',' ); > + buf.append( "," ); > } > } > - buf.append( ')' ); > + buf.append( ")" ); > return buf.toString(); > } > } > Index: jndi-provider/src/java/org/apache/eve/db/jdbm/JdbmDatabase.java > =================================================================== > --- jndi-provider/src/java/org/apache/eve/db/jdbm/JdbmDatabase.java (revision 109245) > +++ jndi-provider/src/java/org/apache/eve/db/jdbm/JdbmDatabase.java (working copy) > @@ -1035,7 +1035,7 @@ > IndexRecord rec = ( IndexRecord ) list.next(); > val.append( "_existance[" ); > val.append( rec.getIndexKey() ); > - val.append( ']' ); > + val.append( "]" ); > attributes.put( val.toString(), rec.getEntryId() ); > val.setLength( 0 ); > } > Index: jndi-provider/src/java/org/apache/eve/db/jdbm/JdbmTable.java > =================================================================== > --- jndi-provider/src/java/org/apache/eve/db/jdbm/JdbmTable.java (revision 109245) > +++ jndi-provider/src/java/org/apache/eve/db/jdbm/JdbmTable.java (working copy) > @@ -1059,7 +1059,7 @@ > { > StringBuffer buf = new StringBuffer(); > - buf.append( '\'' ); > + buf.append( "\'" ); > if ( null == renderer ) > { > buf.append( obj.toString() ); > @@ -1069,7 +1069,7 @@ > buf.append( renderer.getKeyString( obj ) ); > } > - buf.append( '\'' ); > + buf.append( "\'" ); > return buf.toString(); > } > Index: jndi-provider/src/java/org/apache/eve/db/gui/MainFrame.java > =================================================================== > --- jndi-provider/src/java/org/apache/eve/db/gui/MainFrame.java (revision 109245) > +++ jndi-provider/src/java/org/apache/eve/db/gui/MainFrame.java (working copy) > @@ -678,11 +678,21 @@ > SearchResultDialog results = new SearchResultDialog( this, false ); > StringBuffer buf = new StringBuffer(); > - buf.append( "base: " ).append( base ).append( '\n' ); > - buf.append( "scope: " ).append( scope ).append( '\n' ); > - buf.append( "limit: " ).append( limit ).append( '\n' ); > - buf.append( "total: " ).append( count ).append( '\n' ); > - buf.append( "filter:\n" ).append( filter ).append( '\n' ); > + buf.append( "base: " ); > + buf.append( base ); > + buf.append( "\n" ); > + buf.append( "scope: " ); > + buf.append( scope ); > + buf.append( "\n" ); > + buf.append( "limit: " ); > + buf.append( limit ); > + buf.append( "\n" ); > + buf.append( "total: " ); > + buf.append( count ); > + buf.append( "\n" ); > + buf.append( "filter:\n" ); > + buf.append( filter ); > + buf.append( "\n" ); > results.setFilter( buf.toString() ); > TreeNode astRoot = new ASTNode( null, root ); > Index: jndi-provider/src/java/org/apache/eve/db/gui/EntryNode.java > =================================================================== > --- jndi-provider/src/java/org/apache/eve/db/gui/EntryNode.java (revision 109245) > +++ jndi-provider/src/java/org/apache/eve/db/gui/EntryNode.java (working copy) > @@ -195,7 +195,9 @@ > try > { > LdapName dn = new LdapName( db.getEntryDn( id ) ); > - buf.append( '(' ).append( id ).append( ") " ); > + buf.append( "(" ); > + buf.append( id ); > + buf.append( ") " ); > buf.append( dn.getRdn() ); > } > catch( NamingException e ) > @@ -206,7 +208,9 @@ > if ( children.size() > 0 ) > { > - buf.append( " [" ).append( children.size() ).append( ']' ); > + buf.append( " [" ); > + buf.append( children.size() ); > + buf.append( "]" ); > } > return buf.toString(); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira