directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Trustin Lee (JIRA)" <directory-...@incubator.apache.org>
Subject [jira] Commented: (DIREVE-90) (Java 5) append().append() fix, append(char) IOException fix
Date Sun, 20 Mar 2005 16:23:21 GMT
     [ http://issues.apache.org/jira/browse/DIREVE-90?page=comments#action_61271 ]
     
Trustin Lee commented on DIREVE-90:
-----------------------------------

This issue came from AspectJ 1.2.x which lacks Java 5 support.  We'll have to use AspectJ
5 or any other AOP framework that supports Java 5 such as AspectWerkz.

> (Java 5) append().append() fix, append(char) IOException fix
> ------------------------------------------------------------
>
>          Key: DIREVE-90
>          URL: http://issues.apache.org/jira/browse/DIREVE-90
>      Project: Directory Server
>         Type: Bug
>  Environment: Java 5
>     Reporter: Mark Swanson
>     Assignee: Alex Karasulu

>
> Here is a patch for the mentioned issues:
> Index: jndi-provider/src/java/org/apache/eve/jndi/InvocationMethodEnum.java
> ===================================================================
> --- jndi-provider/src/java/org/apache/eve/jndi/InvocationMethodEnum.java       (revision
109245)
> +++ jndi-provider/src/java/org/apache/eve/jndi/InvocationMethodEnum.java       (working
copy)
> @@ -305,7 +305,7 @@
>      {
>          StringBuffer buf = new StringBuffer();
>          buf.append( method.getName() );
> -        buf.append( '(' );
> +        buf.append( "(" );
>          Class[] params = method.getParameterTypes();
>          for ( int ii = 0; ii < params.length; ii++ )
> @@ -314,11 +314,11 @@
>              if ( ii < params.length - 1 )
>              {
> -                buf.append( ',' );
> +                buf.append( "," );
>              }
>          }
> -        buf.append( ')' );
> +        buf.append( ")" );
>          return buf.toString();
>      }
>  }
> Index: jndi-provider/src/java/org/apache/eve/db/jdbm/JdbmDatabase.java
> ===================================================================
> --- jndi-provider/src/java/org/apache/eve/db/jdbm/JdbmDatabase.java     (revision 109245)
> +++ jndi-provider/src/java/org/apache/eve/db/jdbm/JdbmDatabase.java     (working copy)
> @@ -1035,7 +1035,7 @@
>              IndexRecord rec = ( IndexRecord ) list.next();
>              val.append( "_existance[" );
>              val.append( rec.getIndexKey() );
> -            val.append( ']' );
> +            val.append( "]" );
>              attributes.put( val.toString(), rec.getEntryId() );
>              val.setLength( 0 );
>          }
> Index: jndi-provider/src/java/org/apache/eve/db/jdbm/JdbmTable.java
> ===================================================================
> --- jndi-provider/src/java/org/apache/eve/db/jdbm/JdbmTable.java        (revision 109245)
> +++ jndi-provider/src/java/org/apache/eve/db/jdbm/JdbmTable.java        (working copy)
> @@ -1059,7 +1059,7 @@
>      {
>          StringBuffer buf = new StringBuffer();
> -        buf.append( '\'' );
> +        buf.append( "\'" );
>          if ( null == renderer )
>          {
>              buf.append( obj.toString() );
> @@ -1069,7 +1069,7 @@
>              buf.append( renderer.getKeyString( obj ) );
>          }
> -        buf.append( '\'' );
> +        buf.append( "\'" );
>          return buf.toString();
>      }
> Index: jndi-provider/src/java/org/apache/eve/db/gui/MainFrame.java
> ===================================================================
> --- jndi-provider/src/java/org/apache/eve/db/gui/MainFrame.java (revision 109245)
> +++ jndi-provider/src/java/org/apache/eve/db/gui/MainFrame.java (working copy)
> @@ -678,11 +678,21 @@
>          SearchResultDialog results = new SearchResultDialog( this, false );
>          StringBuffer buf = new StringBuffer();
> -        buf.append( "base: " ).append( base ).append( '\n' );
> -        buf.append( "scope: " ).append( scope ).append( '\n' );
> -        buf.append( "limit: " ).append( limit ).append( '\n' );
> -        buf.append( "total: " ).append( count ).append( '\n' );
> -        buf.append( "filter:\n" ).append( filter ).append( '\n' );
> +        buf.append( "base: " );
> +               buf.append( base );
> +               buf.append( "\n" );
> +        buf.append( "scope: " );
> +               buf.append( scope );
> +               buf.append( "\n" );
> +        buf.append( "limit: " );
> +               buf.append( limit );
> +               buf.append( "\n" );
> +        buf.append( "total: " );
> +               buf.append( count );
> +               buf.append( "\n" );
> +        buf.append( "filter:\n" );
> +               buf.append( filter );
> +               buf.append( "\n" );
>          results.setFilter( buf.toString() );
>             TreeNode astRoot = new ASTNode( null, root );
> Index: jndi-provider/src/java/org/apache/eve/db/gui/EntryNode.java
> ===================================================================
> --- jndi-provider/src/java/org/apache/eve/db/gui/EntryNode.java (revision 109245)
> +++ jndi-provider/src/java/org/apache/eve/db/gui/EntryNode.java (working copy)
> @@ -195,7 +195,9 @@
>          try
>          {
>              LdapName dn = new LdapName( db.getEntryDn( id ) );
> -            buf.append( '(' ).append( id ).append( ") " );
> +            buf.append( "(" );
> +                       buf.append( id );
> +                       buf.append( ") " );
>              buf.append( dn.getRdn() );
>          }
>          catch( NamingException e )
> @@ -206,7 +208,9 @@
>          if ( children.size() > 0 )
>          {
> -            buf.append( " [" ).append( children.size() ).append( ']' );
> +            buf.append( " [" );
> +                       buf.append( children.size() );
> +                       buf.append( "]" );
>          }
>          return buf.toString();

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Mime
View raw message