directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Karasulu <aok...@bellsouth.net>
Subject Re: svn commit: r159056 - in directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search: AndRule.java OrRule.java
Date Fri, 25 Mar 2005 20:18:18 GMT
Please excuse the sporadic changes ... I thought the patch broke 
something, then reverted, then found that stuff was broken before.  For 
some reason things broke  with my changes but maven did not complain 
allowing me to deploy the jars without bombing on test cases.  I'll look 
into what's going on before acting quickly.

Thanks for your patience.
Alex

akarasulu@apache.org wrote:

>Author: akarasulu
>Date: Fri Mar 25 12:15:26 2005
>New Revision: 159056
>
>URL: http://svn.apache.org/viewcvs?view=rev&rev=159056
>Log:
>alright going forward with changes yet again - seems like this patch did not break it
but something before did
>
>Modified:
>    directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java
>    directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java
>
>Modified: directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java
>URL: http://svn.apache.org/viewcvs/directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java?view=diff&r1=159055&r2=159056
>==============================================================================
>--- directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java
(original)
>+++ directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/AndRule.java
Fri Mar 25 12:15:26 2005
>@@ -138,7 +138,8 @@
> 
>             while( getDigester().peek() instanceof ExprNode )
>             {
>-                node.addNode( ( ExprNode ) getDigester().pop() );
>+                // TODO correct obvious performance hit here if this code stays around.
>+                node.addNodeToHead( ( ExprNode ) getDigester().pop() );
>             }
> 
>             if ( getDigester().peek() == this )
>@@ -153,10 +154,6 @@
> 
>                 throw new IllegalStateException( msg );
>             }
>-
>-            StringBuffer strbuf = new StringBuffer( );
>-
>-            node.printToBuffer( strbuf );
> 
>             getDigester().push( node );
>         }
>
>Modified: directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java
>URL: http://svn.apache.org/viewcvs/directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java?view=diff&r1=159055&r2=159056
>==============================================================================
>--- directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java
(original)
>+++ directory/shared/ldap/trunk/apache-provider/src/java/org/apache/ldap/common/berlib/asn1/decoder/search/OrRule.java
Fri Mar 25 12:15:26 2005
>@@ -140,7 +140,8 @@
> 
>             while( getDigester().peek() instanceof ExprNode )
>             {
>-                node.addNode( ( ExprNode ) getDigester().pop() );
>+                // TODO correct obvious performance hit here if this code stays around.
>+                node.addNodeToHead( ( ExprNode ) getDigester().pop() );
>             }
> 
>             if ( getDigester().peek() == this )
>@@ -155,10 +156,6 @@
> 
>                 throw new IllegalStateException( msg );
>             }
>-
>-            StringBuffer strbuf = new StringBuffer( );
>-
>-            node.printToBuffer( strbuf );
> 
>             getDigester().push( node );
>         }
>
>
>
>  
>


Mime
View raw message