directory-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <br...@apache.org>
Subject Re: svn commit: r157092 - incubator/directory/network/mina/trunk/project.xml
Date Fri, 11 Mar 2005 17:45:56 GMT
I think it's the reverse: you're only excluding those classes in JDK 1.5 
with the below.

I've never used source modifications - they were tossed in as a quick 
fix. Even if it is a small library, I think it is preferable to make a 
separate JAR for these. WDYT?

- Brett

Alex Karasulu wrote:

> Hi Brett,
>
> Ya know why this might not be working?  In JDK 1.4 there is no 
> SSLEngine class so one would expect these classes to not be included 
> in the build.  However they still are.   Is there some property I need 
> to tweak to make this stick?
>
> Thanks,
>  -- Alex
>
> akarasulu@apache.org wrote:
>
>> Author: akarasulu
>> Date: Fri Mar 11 07:12:15 2005
>> New Revision: 157092
>>
>> URL: http://svn.apache.org/viewcvs?view=rev&rev=157092
>> Log:
>> These changes are supposed to make it so we can compile MINA fine in 
>> 1.4 or 1.5 land but it seems to not work for some reason.  Basically 
>> if the SSLEngine
>> is not found the classes under excludes will not be included in the 
>> compile.
>>
>> NOTE: check with Brett if this feature is still used in Maven 1.0.2
>>
>>
>> Modified:
>>    incubator/directory/network/mina/trunk/project.xml
>>
>> Modified: incubator/directory/network/mina/trunk/project.xml
>> URL: 
>> http://svn.apache.org/viewcvs/incubator/directory/network/mina/trunk/project.xml?view=diff&r1=157091&r2=157092

>>
>> ============================================================================== 
>>
>> --- incubator/directory/network/mina/trunk/project.xml (original)
>> +++ incubator/directory/network/mina/trunk/project.xml Fri Mar 11 
>> 07:12:15 2005
>> @@ -119,6 +119,16 @@
>>   <build>
>>     
>> <nagEmailAddress>directory-dev@incubator.apache.org</nagEmailAddress>
>>     <sourceDirectory>${basedir}/src/java</sourceDirectory>
>> +    <sourceModifications>
>> +      <sourceModification>
>> +        <className>javax.net.ssl.SSLEngine</className>
>> +        <excludes>
>> +          <exclude>**/SSLFilter.java</exclude>
>> +          <exclude>**/SSLHandler.java</exclude>
>> +          <exclude>**/SSLByteBufferPool.java</exclude>
>> +        </excludes>
>> +      </sourceModification>
>> +    </sourceModifications>
>>     
>> <unitTestSourceDirectory>${basedir}/src/test</unitTestSourceDirectory>
>>     <integrationUnitTestSourceDirectory/>
>>     <aspectSourceDirectory/>
>>
>>
>>
>>  
>>
>
>


Mime
View raw message