From directory-dev-return-4043-apmail-incubator-directory-dev-archive=incubator.apache.org@incubator.apache.org Tue Feb 01 16:09:26 2005 Return-Path: Delivered-To: apmail-incubator-directory-dev-archive@www.apache.org Received: (qmail 33484 invoked from network); 1 Feb 2005 16:09:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 1 Feb 2005 16:09:25 -0000 Received: (qmail 88624 invoked by uid 500); 1 Feb 2005 16:09:17 -0000 Delivered-To: apmail-incubator-directory-dev-archive@incubator.apache.org Received: (qmail 88553 invoked by uid 500); 1 Feb 2005 16:09:16 -0000 Mailing-List: contact directory-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list directory-dev@incubator.apache.org Received: (qmail 88514 invoked by uid 99); 1 Feb 2005 16:09:16 -0000 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=FORGED_RCVD_HELO X-Spam-Check-By: apache.org Received-SPF: neutral (hermes.apache.org: local policy) Received: from smtp5.wanadoo.fr (HELO smtp5.wanadoo.fr) (193.252.22.26) by apache.org (qpsmtpd/0.28) with ESMTP; Tue, 01 Feb 2005 08:09:16 -0800 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf0504.wanadoo.fr (SMTP Server) with ESMTP id AF61D1C00196 for ; Tue, 1 Feb 2005 17:09:12 +0100 (CET) Received: from 192.168.0.4 (APh-Aug-102-2-1-32.w193-252.abo.wanadoo.fr [193.252.40.32]) by mwinf0504.wanadoo.fr (SMTP Server) with ESMTP id 6B07A1C00195 for ; Tue, 1 Feb 2005 17:09:12 +0100 (CET) X-ME-UUID: 20050201160912438.6B07A1C00195@mwinf0504.wanadoo.fr Subject: Re: [jira] Commented: (DIRLDAP-31) Commons.Cli implemented in Bind From: Emmanuel Lecharny To: "Alex Karasulu (JIRA)" In-Reply-To: <458684031.1107272057682.JavaMail.jira@ajax.apache.org> References: <458684031.1107272057682.JavaMail.jira@ajax.apache.org> Content-Type: text/plain; charset=ISO-8859-15 Date: Tue, 01 Feb 2005 17:09:49 +0100 Message-Id: <1107274189.5485.33.camel@portable.iktek.com> Mime-Version: 1.0 X-Mailer: Evolution 2.0.2 (2.0.2-3) Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N I will stick to those conventions. I really like those m_ prefix, as I have spent hours catching those kind of "name = name;" errors. Wathever. Good style, bad style, at least have a style! I buy your style, I'm very close to it ("Writing" solid code, that was a good basis to begin with. M$ should have read it ;) I'm working with Eclipse, but I could try a switch. I'm still in the process to work out a complete common-cli solution for Client (almost done). I'm also fighting against svn diff that does not skip spaces differences. May I use : svn diff --diff-cmd /usr/bin/diff --extensions '-bBw' ? Le mardi 01 février 2005 à 16:34 +0100, Alex Karasulu (JIRA) a écrit : > [ http://issues.apache.org/jira/browse/DIRLDAP-31?page=comments#action_58406 ] > > Alex Karasulu commented on DIRLDAP-31: > -------------------------------------- > > I need to clarify what our convention is. Personally I change as I discover cleaner styles out there. Right now I think the cleanest style I have ever encountered is Jason Van Zyl's. Just look at any recent commits of mine to see it. > > To specifically answer your questions... > > -> Client code uses old old style way back when so no need to follow > > -> Keep {} on separate lines always > > -> space pad () > > -> if, else, while, for, try, catch all on new lines > > -> throw away the m_, a_ and l_ conventions ( go with using this. and super.) > > -> yeah I need to get off my but and get a Jalopy and/or Checkstyle worked out for this style: Jason's style is really easy to read on my eyes. > > -> I use IDEA. We actually have a license for the directory project that was donated to us. Let me know if you would like to use this to write directory code. > > Cheers, > -Alex > > > Commons.Cli implemented in Bind > > ------------------------------- > > > > Key: DIRLDAP-31 > > URL: http://issues.apache.org/jira/browse/DIRLDAP-31 > > Project: Directory LDAP > > Type: Improvement > > Components: Clients > > Versions: 0.8.0 > > Reporter: Emmanuel Lecharny > > Assignee: Alex Karasulu > > Priority: Minor > > > > > I've implemented commons.cli in Bind, it works (also used log4j) : > > FATAL org.apache.ldap.clients.LdapBind - Error while parsing command line arguments : Unrecognized option: -k > > INFO org.apache.ldap.clients.LdapBind - Command line arguments : -k 127.0.0.1 -p 389 -D cn=Manager,dc=iktek,dc=com -w secret -v > > usage: Bind > > -D,--binddn bind DN > > -P,--protocol procotol version (default: 3) > > -h,--host LDAP server > > -n,--noupdate show what would be done but don't actually update > > -p,--port port on LDAP server > > -v,--verbose run in verbose mode (diagnostics to standard output) > > -w,--passwd bind passwd (for simple authentication) >