Return-Path: Delivered-To: apmail-incubator-directory-dev-archive@www.apache.org Received: (qmail 41110 invoked from network); 12 Dec 2004 15:18:31 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 12 Dec 2004 15:18:31 -0000 Received: (qmail 51720 invoked by uid 500); 12 Dec 2004 15:18:30 -0000 Delivered-To: apmail-incubator-directory-dev-archive@incubator.apache.org Received: (qmail 51689 invoked by uid 500); 12 Dec 2004 15:18:30 -0000 Mailing-List: contact directory-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Apache Directory Developers List" Delivered-To: mailing list directory-dev@incubator.apache.org Received: (qmail 51674 invoked by uid 99); 12 Dec 2004 15:18:30 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from devtech.com (HELO mail.devtech.com) (66.112.202.2) by apache.org (qpsmtpd/0.28) with SMTP; Sun, 12 Dec 2004 07:18:28 -0800 Received: from localhost ([127.0.0.1]) by mail.devtech.com (JAMES SMTP Server 2.2.1-dev) with SMTP ID 512 for ; Sun, 12 Dec 2004 10:18:21 -0500 (EST) From: "Noel J. Bergman" To: "Apache Directory Developers List" Subject: Commenting code Date: Sun, 12 Dec 2004 10:18:21 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-Reply-To: <41BC00DE.9040006@bellsouth.net> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1441 Importance: Normal X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Alex wrote: > I fixed this in the following revision: > http://svn.apache.org/viewcvs?view=rev&rev=111644 One thing I am noticing, just as an example, is that when fixes are put into the repository, we have a decent description of the fix in the commit log, but comments are relatively sparse. My general comment is that I'm not seeing code commented as if some other programmer would have to work on it. Yes, tend to have a description of each method, and usually something on branch points, but I comments are explanations to some other programmer (as well as reminders to ourselves some months or years later) as to what the code is doing and why it is important. This observation is certainly not limited to this project, but reading through recent commits inspired me to prod everyone to comment code. --- Noel