Return-Path: 
 <directory-dev-return-3288-apmail-incubator-directory-dev-archive=incubator.apache.org@incubator.apache.org>
Delivered-To: apmail-incubator-directory-dev-archive@www.apache.org
Received: (qmail 17693 invoked from network); 22 Dec 2004 11:45:02 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur-2.apache.org with SMTP; 22 Dec 2004 11:45:02 -0000
Received: (qmail 54742 invoked by uid 500); 22 Dec 2004 11:43:45 -0000
Delivered-To: apmail-incubator-directory-dev-archive@incubator.apache.org
Received: (qmail 54693 invoked by uid 500); 22 Dec 2004 11:43:45 -0000
Mailing-List: contact directory-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:directory-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:directory-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:directory-dev@incubator.apache.org>
List-Id: <directory-dev.incubator.apache.org>
Reply-To: "Apache Directory Developers List"
 <directory-dev@incubator.apache.org>
Delivered-To: mailing list directory-dev@incubator.apache.org
Received: (qmail 54674 invoked by uid 99); 22 Dec 2004 11:43:43 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: neutral (hermes.apache.org: local policy)
Received: from ensim1.25oz.com (HELO ensim1.25oz.com) (216.40.203.202)
  by apache.org (qpsmtpd/0.28) with ESMTP; Wed, 22 Dec 2004 03:43:40 -0800
Received: from [192.168.0.100] (h002078d1eba8.ne.client2.attbi.com
 [66.30.206.209])
	(authenticated bits=0)
	by ensim1.25oz.com (8.12.10/8.12.10) with ESMTP id iBMCAASt017110
	for <directory-dev@incubator.apache.org>; Wed, 22 Dec 2004 07:10:11 -0500
Message-ID: <41C95DE2.9090400@apache.org>
Date: Wed, 22 Dec 2004 06:43:30 -0500
From: Enrique Rodriguez <erodriguez@apache.org>
User-Agent: Mozilla Thunderbird 1.0 (X11/20041206)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: directory-dev@incubator.apache.org
Subject: failing testGetGeneralizedTime()
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

Alex et al,

Regarding the failing timezone test, the draft reference at:

http://ietf.org/internet-drafts/draft-ietf-ldapbis-syntaxes-09.txt

states:

"The "Z" form of <g-time-zone> SHOULD be used in preference to 
<g-differential>."

but in org.apache.eve.jndi.ibs.OperationalAttributeService you are using 
<g-differential> 5 times with no explicit Z TimeZone to set the String 
time on modified attributes.

I propose:

1)  Move to "The "Z" form of <g-time-zone>" for this function, per the 
draft.

2)  Replace DateUtils with the following 3 lines of code, as a 
convenience method in the OperationalAttributeService, since that is the 
only place this is used (best I can tell, quick IDE reference check).


private String getGeneralizedTimeStamp()
{
   SimpleDateFormat date = new SimpleDateFormat( "yyyyMMddHHmmss'Z'" );
   date.setTimeZone( new SimpleTimeZone(0,"Z") );
   return date.format( new Date() );
}

... or is there a reason to use <g-differential> in that service?  Say 
the word and I'll commit this change.

-enrique